这是indexloc提供的服务，不要输入任何密码
Skip to content

on a conn_init error send connection_err message instead of closing the ws conn (fix #537) #572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 29, 2018
Merged

on a conn_init error send connection_err message instead of closing the ws conn (fix #537) #572

merged 3 commits into from
Sep 29, 2018

Conversation

@0x777
Copy link
Member

@0x777 0x777 commented Sep 28, 2018

Description

What component does this PR affect?

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System

Requires changes from other components? If yes, please mark the components:

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System

Related Issue

#537

Solution and Design

Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Docs update
  • Community content

Checklist:

  • I have read the contributing guide and my code conforms to the guidelines.
  • This change requires a change in the documentation.
  • I have updated the documentation accordingly.
  • I have added required tests.

@0x777 0x777 changed the title on a conn_init error send connection_err message before closing the ws connection on a conn_init error send connection_err message and do not close the connection Sep 29, 2018
@0x777
Copy link
Member Author

0x777 commented Sep 29, 2018

@arvi3411301 It is now according to spec. Can you test for this?

@0x777 0x777 changed the title on a conn_init error send connection_err message and do not close the connection on a conn_init error send connection_err message instead of closing the ws conn Sep 29, 2018
@shahidhk shahidhk changed the title on a conn_init error send connection_err message instead of closing the ws conn on a conn_init error send connection_err message instead of closing the ws conn (fix #537) Sep 29, 2018
@shahidhk shahidhk merged commit 67ee3fc into master Sep 29, 2018
@hasura-bot
Copy link
Contributor

hasura-bot commented Sep 29, 2018

Review app https://hge-ci-pull-572.herokuapp.com is deleted

@shahidhk shahidhk deleted the issue-537 branch September 29, 2018 07:52
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Aug 29, 2022 •
edited
Loading

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: fde7277
Status:🚫  Build failed.

View logs

hasura-bot pushed a commit that referenced this pull request May 13, 2024
@dependabot @hasura-bot
Bump async-graphql-parser from 7.0.3 to 7.0.5 (#572)
ba43f6c 
V3_GIT_ORIGIN_REV_ID: 7550ef5800612f95715c49b722db8885e9b251b4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shahidhk shahidhk shahidhk approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@0x777 @hasura-bot @shahidhk