do not clean hdb_views by dropping and creating the schema (closes #567) #568
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rakeshkky
approved these changes
Sep 28, 2018
Contributor
|
Review app https://hge-ci-pull-568.herokuapp.com is deleted |
hasura-bot
pushed a commit
that referenced
this pull request
May 13, 2024
…ve` (#568) <!-- Thank you for submitting this PR! :) --> ## Description We're adding some tests that compare the output of metadata resolve. Unfortunately, the results are nondeterministic because we use `HashMap` / `HashSet` in a lot of places. This replaces those uses with `BTreeMap` and `BTreeSet` in `metadata-resolve`, and in a few places in `schema` that rely on those types. Some light reading around suggests that as well as giving us consistent ordering, `BTree-` versions are better in terms of memory usage, esp with < 1000 items (which I'm pretty sure most metadata items are) https://www.reddit.com/r/rust/comments/xbkuc7/btreemap_vs_hashmap/ https://users.rust-lang.org/t/hashmap-vs-btreemap/13804/2 https://iq.opengenus.org/hashmap-and-btreemap-rust/ Functional no-op. V3_GIT_ORIGIN_REV_ID: dbf49aefef0cd7084a3a37ef4fe9fc61257e1305
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix migration logic to accommodate for non superuser permissions. Closes #567
Description
What component does this PR affect?
Requires changes from other components? If yes, please mark the components:
Related Issue
#567
Solution and Design
By clearing the
hdb_viewsschema of existing views and functions instead of dropping and creating it again.Type
Checklist: