fix non-admin insert returns null column values when query affects zero rows in postgres (fix #563) #565
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Review app available at: https://hge-ci-pull-565.herokuapp.com |
0x777
reviewed
Sep 28, 2018
server/src-rsr/insert_trigger.sql.j2
Outdated
| VALUES (NEW.*) ; IF FOUND THEN RETURN NEW; ELSE RETURN null; END IF; | ||
| ELSE | ||
| action = conflict_clause ->> 'action'; | ||
| constraint_name = conflict_clause ->> 'constraint'; |
Member
There was a problem hiding this comment.
constraint_name = quote_ident(conflict_clause ->> 'constraint');
0x777
reviewed
Sep 28, 2018
server/src-rsr/insert_trigger.sql.j2
Outdated
| IF action is NOT NULL THEN | ||
| CASE | ||
| WHEN action = 'ignore'::text AND constraint_name IS NULL THEN | ||
| INSERT INTO {{table_name}} VALUES (NEW.*) ON CONFLICT DO NOTHING; IF FOUND THEN RETURN NEW; ELSE RETURN null; END IF; |
Member
There was a problem hiding this comment.
Why not add IF FOUND THEN RETURN NEW; ELSE RETURN null; END IF; before the end of the case statement?
Contributor
|
Review app available at: https://hge-ci-pull-565.herokuapp.com |
0x777
approved these changes
Sep 29, 2018
shahidhk
approved these changes
Sep 29, 2018
Contributor
|
Review app https://hge-ci-pull-565.herokuapp.com is deleted |
Deploying with
|
| Latest commit: |
746cae5
|
| Status: | 🚫 Build failed. |
hasura-bot
pushed a commit
that referenced
this pull request
May 14, 2024
## Description Fixes https://hasurahq.atlassian.net/browse/V3ENGINE-134 The problem is caused by a local relationship with multiple remote joins inside. The `not_nested` case passes, but `nested` and `very_nested` fail. The root cause of the problem was wrong assumption in the collecting of join arguments code. This PR fixes it, and also refactors the remote joins execution code to make it easier (hopefully) to follow . --------- Co-authored-by: Anon Ray <rayanon004@gmail.com> Co-authored-by: Anon Ray <ecthiender@users.noreply.github.com> V3_GIT_ORIGIN_REV_ID: 52f5449261406da51a3a6ea7d96d1b166220e8fe
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Insert trigger function: If query affects no rows then return
nullWhat component does this PR affect?
Requires changes from other components? If yes, please mark the components:
Related Issue
Fix #563
Solution and Design
Insert trigger function is modified to have
IF r IS NULL THEN RETURN null; ELSE RETURN r; END IF;in return statement.Type
Checklist: