这是indexloc提供的服务，不要输入任何密码
Skip to content

add tooltip for upsert option under custom permissions (fix #546) #566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 2, 2018
Merged

add tooltip for upsert option under custom permissions (fix #546) #566

merged 1 commit into from
Oct 2, 2018

Conversation

@paranoidsp
Copy link
Contributor

@paranoidsp paranoidsp commented Sep 28, 2018

Description

What component does this PR affect?

  • Server
  • [ x ] Console
  • CLI
  • Docs
  • Community Content
  • Build System

Requires changes from other components? If yes, please mark the components:

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System

Related Issue

Solution and Design

Type

  • [ x ] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Docs update
  • Community content

Checklist:

  • [ x ] I have read the contributing guide and my code conforms to the guidelines.
  • This change requires a change in the documentation.
  • I have updated the documentation accordingly.
  • I have added required tests.

@karthikvt26 karthikvt26 added the c/console Related to console label Sep 28, 2018
@karthikvt26 karthikvt26 added this to the Biweekly sprint for console [24 Sep - 5 Oct] milestone Sep 28, 2018
@hasura-bot
Copy link
Contributor

hasura-bot commented Sep 28, 2018

Review app available at: https://hge-ci-pull-566.herokuapp.com

@praveenweb praveenweb self-requested a review October 2, 2018 05:40
praveenweb
praveenweb approved these changes Oct 2, 2018
View reviewed changes
Copy link
Member

@praveenweb praveenweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@praveenweb praveenweb added the s/ok-to-merge Status: This pull request can be merged to master label Oct 2, 2018
@shahidhk
Copy link
Member

shahidhk commented Oct 2, 2018

@karthikvt26 You said you had some feedback here, is it taken care of?

@karthikvt26
Copy link
Contributor

karthikvt26 commented Oct 2, 2018

@shahidhk I was going for a different text. Because current text doesn't tell the fact that you can make upsert queries only if you check it. @paranoidsp is fixing it.

@karthikvt26 karthikvt26 added s/do-not-merge Do not merge this pull request to master and removed s/ok-to-merge Status: This pull request can be merged to master labels Oct 2, 2018
@praveenweb
Copy link
Member

praveenweb commented Oct 2, 2018

@karthikvt26 - Isn't the text implicit that you need to select the checkbox to allow?

@karthikvt26
Copy link
Contributor

karthikvt26 commented Oct 2, 2018

Agree. Lets merge it then.

@karthikvt26 karthikvt26 added s/ok-to-merge Status: This pull request can be merged to master and removed s/do-not-merge Do not merge this pull request to master labels Oct 2, 2018
@shahidhk shahidhk merged commit f34338f into hasura:master Oct 2, 2018
@hasura-bot
Copy link
Contributor

hasura-bot commented Oct 2, 2018

Review app https://hge-ci-pull-566.herokuapp.com is deleted

@Allymahmoud Allymahmoud mentioned this pull request Jun 20, 2023
Open
hasura-bot pushed a commit that referenced this pull request May 10, 2024
@danieljharvey @hasura-bot
Replace mutation in remote joins with more explicit return types (#566)
42b1a63 
Found some of the remote join argument collection a little tricky to
follow, so changed it to be a little more explicit. It is still broken
for nested remote joins inside local ones, but at least is more explicit
about it's behaviour regarding returning joins.

Functional no-op.

V3_GIT_ORIGIN_REV_ID: 77d4717ee9d5effc1c08bcf5f4fbcf0af9f5d777
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@praveenweb praveenweb praveenweb approved these changes

@karthikvt26 karthikvt26 karthikvt26 approved these changes

Assignees

No one assigned

Labels

c/console Related to console s/ok-to-merge Status: This pull request can be merged to master

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@paranoidsp @hasura-bot @shahidhk @karthikvt26 @praveenweb