console: improve UI for nested remote relationships (close #4973) #5612
Conversation
|
Deploy preview for hasura-docs ready! Built with commit f176df7 |
|
Review app for commit fed811a deployed to Heroku: https://hge-ci-pull-5612.herokuapp.com |
|
Review app for commit 9ace4f5 deployed to Heroku: https://hge-ci-pull-5612.herokuapp.com |
kolharsam
left a comment
There was a problem hiding this comment.
Code wise it looks good! 👍
| const parseRelationship = parseRemoteRelationship(relationship); | ||
| const relationMap = () => { | ||
| const fields = parseRelationship.remoteFields.map(field => field.name); | ||
| return ['', ...fields].join(' →'); |
There was a problem hiding this comment.
We should probably add more spacing here. The deeper the nesting, the more congested it might look. See image below for context.
| {`- ${relationship.table_name} → ${ | ||
| relationship.definition.remote_schema | ||
| } . ${Object.keys(relationship.definition.remote_field)}`} | ||
| } ${relationMap()}`} |
|
Review app for commit 68309ec deployed to Heroku: https://hge-ci-pull-5612.herokuapp.com |
beerose
left a comment
There was a problem hiding this comment.
It looks like the issue was solved, but I have one comment about the UI.
We need something like:
from_column ➡ remote_schema . _field . more_nested_field . even_more_nested_filed . final_field,
so you'd need to use . instead of arrows (except for the first one that is pointing from database column to some remote schema.)
68309ec to
f176df7
Compare
|
Deploy preview for hasura-docs ready! Built with commit 8c55a65 |
closes #4973
Description
This PR improves the representation of remote relationship mapping on console UI.
Affected components
It's gone from being like this :
to something like this: