-
Notifications
You must be signed in to change notification settings - Fork 2.8k
cli: improve error messages for metadata apply (close #5513) #5548
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Review app for commit 7508757 deployed to Heroku: https://hge-ci-pull-5548.herokuapp.com |
tirumaraiselvan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A changelog is definitely worth it :)
|
Review app for commit f6f5994 deployed to Heroku: https://hge-ci-pull-5548.herokuapp.com |
tirumaraiselvan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changelog
shahidhk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Review app https://hge-ci-pull-5548.herokuapp.com is deleted |
Description
The error messages thrown during a failed
metadata applywere not useful, this PR attempts to improve it.Changelog
CHANGELOG.mdis updated with user-facing content relevant to this PR. If no changelog is required, then add theno-changelog-requiredlabel.Affected components
Related Issues
close #5513
Solution and Design
Following is a comparison of errors thrown before and after the change.
Before:
After: