trigger webhooks on column level changes instead of row (close #547, close #680) #550

tirumaraiselvan · 2018-09-27T08:12:41Z

Description

We want to give users ability to listen on events only when certain columns change for a record. Currently, we send events when the record changes even if certain columns did not change.

What component does this PR affect?

Requires changes from other components? If yes, please mark the components:

Related Issue

#547

Solution and Design

Listen on specified columns but send entire record as payload.

Type

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)
Docs update
Community content

Checklist:

I have read the contributing guide and my code conforms to the guidelines.
This change requires a change in the documentation.
I have updated the documentation accordingly.
I have added required tests.

tirumaraiselvan · 2018-09-27T08:16:10Z

@karthikvt26 There are console changes required in the advanced settings of event triggers creation page.

hasura-bot · 2018-09-27T08:36:21Z

Review app available at: https://hge-ci-pull-550.herokuapp.com

tirumaraiselvan · 2018-09-27T08:47:28Z

~~TODO: Dependency changes~~

hasura-bot · 2018-09-27T12:44:41Z

Review app available at: https://hge-ci-pull-550.herokuapp.com

hasura-bot · 2018-09-28T13:40:11Z

Review app available at: https://hge-ci-pull-550.herokuapp.com

hasura-bot · 2018-10-05T10:37:18Z

Review app available at: https://hge-ci-pull-550.herokuapp.com

shahidhk · 2018-10-05T13:11:29Z

@tirumaraiselvan What is the new API?

tirumaraiselvan · 2018-10-05T13:32:21Z

Same as before with an optional payload key in insert,update and delete spec:

{
  "type": "create_event_trigger",
  "args": {
    "name": "testtriggerheaders",
    "table": "users",
    "update": {
      "columns": ["username", "real_name"],
      "payload": "*"
    },
    "insert": {
        "columns": "*",
        "payload": ["username"]
    },
   "delete": {
        "columns": "*"
    },
    "webhook": "https://httpbin.org/post",
    "headers":[
      {
        "name": "X-Hasura-From-Val",
        "value": "myvalueNEW"
      },
      {
        "name": "X-Hasura-From-Env",
        "value_from_env": "EVENT_WEBHOOK_HEADER"
      }
    ]
  }
}

…to column_updates # Conflicts: # server/src-lib/Hasura/RQL/DDL/Subscribe.hs

…ngine into column_updates

hasura-bot · 2018-10-15T06:50:40Z

Review app available at: https://hge-ci-pull-550.herokuapp.com

hasura-bot · 2018-10-15T07:01:14Z

Review app available at: https://hge-ci-pull-550.herokuapp.com

hasura-bot · 2018-10-15T08:18:02Z

Review app available at: https://hge-ci-pull-550.herokuapp.com

hasura-bot · 2018-10-15T08:29:33Z

Review app available at: https://hge-ci-pull-550.herokuapp.com

hasura-bot · 2018-10-15T13:29:36Z

Review app available at: https://hge-ci-pull-550.herokuapp.com

hasura-bot · 2018-10-16T07:14:25Z

Review app available at: https://hge-ci-pull-550.herokuapp.com

hasura-bot · 2018-10-17T08:44:23Z

Review app available at: https://hge-ci-pull-550.herokuapp.com

hasura-bot · 2018-10-22T06:55:16Z

Review app available at: https://hge-ci-pull-550.herokuapp.com

…_updates

hasura-bot · 2018-10-24T09:06:06Z

Review app available at: https://hge-ci-pull-550.herokuapp.com

hasura-bot · 2018-10-24T10:28:08Z

Review app available at: https://hge-ci-pull-550.herokuapp.com

0x777 · 2018-10-24T10:32:05Z

server/src-lib/Hasura/RQL/DDL/Subscribe.hs

          getColInfos cols allCols
+    fromMaybePayload :: Maybe SubscribeColumns -> SubscribeColumns
+    fromMaybePayload (Just sc) = sc
+    fromMaybePayload Nothing   = SubCStar


use fromMaybe from Data.Maybe.

hasura-bot · 2018-10-24T11:13:47Z

Review app available at: https://hge-ci-pull-550.herokuapp.com

hasura-bot · 2018-10-25T04:44:13Z

Review app available at: https://hge-ci-pull-550.herokuapp.com

hasura-bot · 2018-10-25T07:22:54Z

Review app https://hge-ci-pull-550.herokuapp.com is deleted

…#547, close hasura#680) (hasura#550)

cloudflare-workers-and-pages · 2022-08-15T11:38:27Z

Deploying with Cloudflare Pages

Latest commit:	`147927e`
Status:	⚡️ Build in progress...

View logs

V3_GIT_ORIGIN_REV_ID: cc078462ec7713139875b0991e86f670d81b7ae6

push to event_log only if column expressions are changed

1b65f54

tirumaraiselvan force-pushed the column_updates branch from 359490a to 1b65f54 Compare September 27, 2018 08:16

tirumaraiselvan added 2 commits September 27, 2018 17:19

check if column spec is empty and throw error, remove emptycol tests

ce57a2d

update tests for new behaviour of column spec

c756e0a

shahidhk added the c/server Related to server label Sep 27, 2018

schema dependency changes for new behaviour of column spec

2833bb8

shahidhk added the s/do-not-merge Do not merge this pull request to master label Sep 27, 2018

tirumaraiselvan added 2 commits September 27, 2018 18:57

take payload columns also

bf67367

handle older trigger definition if present in db

bb48961

tirumaraiselvan removed the s/do-not-merge Do not merge this pull request to master label Oct 5, 2018

Merge branch 'master' into column_updates

89a94f4

tirumaraiselvan mentioned this pull request Oct 5, 2018

DX for event triggers on column updates #547

Closed

tirumaraiselvan added 3 commits October 15, 2018 12:02

Merge branch 'master' of github.com:tirumaraiselvan/graphql-engine in…

cb3d54e

…to column_updates # Conflicts: # server/src-lib/Hasura/RQL/DDL/Subscribe.hs

Merge branch 'column_updates' of github.com:tirumaraiselvan/graphql-e…

4e9ad47

…ngine into column_updates

no-op reindent

827899f

create row objects for evaluating diff

b3916a1

tirumaraiselvan force-pushed the column_updates branch from 28ad719 to b3916a1 Compare October 15, 2018 08:09

add api-reference docs

9643b45

rikinsk added 2 commits October 15, 2018 18:40

docs: fix guides links syntax

e61e0c5

docs: fix api reference links syntax

4ea0538

tirumaraiselvan added 2 commits October 16, 2018 12:16

fix typo

0f5a305

add payload tests

1705c8e

Merge branch 'master' into column_updates

401e649

Merge branch 'master' into column_updates

04c3aa1

0x777 self-requested a review October 22, 2018 06:27

0x777 previously approved these changes Oct 23, 2018

View reviewed changes

Merge branch 'master' of github.com:hasura/graphql-engine into column…

0b0779e

…_updates

make payload optional

d81e04b

tirumaraiselvan dismissed 0x777’s stale review via d81e04b October 24, 2018 10:07

0x777 reviewed Oct 24, 2018

View reviewed changes

refactor fromMaybePayload

2af6e51

Merge branch 'master' into column_updates

9b18e85

0x777 approved these changes Oct 25, 2018

View reviewed changes

shahidhk changed the title ~~Listen to column expressions instead of whole row (close #547, close #680)~~ trigger webhooks on column level changes instead of whole row (close #547, close #680) Oct 25, 2018

shahidhk changed the title ~~trigger webhooks on column level changes instead of whole row (close #547, close #680)~~ trigger webhooks on column level changes instead of row (close #547, close #680) Oct 25, 2018

shahidhk merged commit 810b440 into hasura:master Oct 25, 2018

rikinsk-zz pushed a commit to rikinsk-zz/graphql-engine that referenced this pull request Oct 25, 2018

trigger webhooks on column level changes instead of row (close hasura…

a15a0c6

…#547, close hasura#680) (hasura#550)

hasura-bot pushed a commit that referenced this pull request May 10, 2024

Bump async-recursion from 1.1.0 to 1.1.1 (#550)

d0ea246

V3_GIT_ORIGIN_REV_ID: cc078462ec7713139875b0991e86f670d81b7ae6

trigger webhooks on column level changes instead of row (close #547, close #680) #550

trigger webhooks on column level changes instead of row (close #547, close #680) #550

Uh oh!

Conversation

tirumaraiselvan commented Sep 27, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related Issue

Solution and Design

Type

Checklist:

Uh oh!

tirumaraiselvan commented Sep 27, 2018

Uh oh!

hasura-bot commented Sep 27, 2018

Uh oh!

tirumaraiselvan commented Sep 27, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hasura-bot commented Sep 27, 2018

Uh oh!

hasura-bot commented Sep 28, 2018

Uh oh!

hasura-bot commented Oct 5, 2018

Uh oh!

shahidhk commented Oct 5, 2018

Uh oh!

tirumaraiselvan commented Oct 5, 2018 • edited by shahidhk Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hasura-bot commented Oct 15, 2018

Uh oh!

hasura-bot commented Oct 15, 2018

Uh oh!

hasura-bot commented Oct 15, 2018

Uh oh!

hasura-bot commented Oct 15, 2018

Uh oh!

hasura-bot commented Oct 15, 2018

Uh oh!

hasura-bot commented Oct 16, 2018

Uh oh!

hasura-bot commented Oct 17, 2018

Uh oh!

hasura-bot commented Oct 22, 2018

Uh oh!

hasura-bot commented Oct 24, 2018

Uh oh!

hasura-bot commented Oct 24, 2018

Uh oh!

0x777 Oct 24, 2018

Choose a reason for hiding this comment

Uh oh!

hasura-bot commented Oct 24, 2018

Uh oh!

hasura-bot commented Oct 25, 2018

Uh oh!

hasura-bot commented Oct 25, 2018

Uh oh!

cloudflare-workers-and-pages bot commented Aug 15, 2022

Deploying with Cloudflare Pages

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

tirumaraiselvan commented Sep 27, 2018 •

edited

Loading

tirumaraiselvan commented Sep 27, 2018 •

edited

Loading

tirumaraiselvan commented Oct 5, 2018 •

edited by shahidhk

Loading