这是indexloc提供的服务，不要输入任何密码
Skip to content

console: update sidebar icons for different action and trigger types #5445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jul 22, 2020
Merged

console: update sidebar icons for different action and trigger types #5445

merged 7 commits into from
Jul 22, 2020

Conversation

@rikinsk
Copy link
Member

@rikinsk rikinsk commented Jul 22, 2020 •
edited
Loading

Description

  • use different icons for query vs mutation type actions
  • use different icons for data vs cron triggers

misc

  • fix spacing between know more and track all button on schema page
  • update cron trigger info image

Changelog

  • CHANGELOG.md is updated with user-facing content relevant to this PR. If no changelog is required, then add the no-changelog-required label.

Affected components

  • Console

Related Issues

Solution and Design

Steps to test and verify

Limitations, known bugs & workarounds

@rikinsk rikinsk requested review from a team as code owners July 22, 2020 10:43
@rikinsk rikinsk added the c/console Related to console label Jul 22, 2020
@rikinsk
Copy link
Member Author

rikinsk commented Jul 22, 2020

/heroku deploy

@hasura-bot
Copy link
Contributor

hasura-bot commented Jul 22, 2020

Review app for commit 0ab9e4d deployed to Heroku: https://hge-ci-pull-5445.herokuapp.com
Docker image for server: hasura/graphql-engine:pull5445-0ab9e4d5

tirumaraiselvan
tirumaraiselvan approved these changes Jul 22, 2020
View reviewed changes
Copy link
Contributor

@tirumaraiselvan tirumaraiselvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changelog

@rikinsk rikinsk merged commit 03305bb into hasura:master Jul 22, 2020
@hasura-bot
Copy link
Contributor

hasura-bot commented Jul 22, 2020

Review app https://hge-ci-pull-5445.herokuapp.com is deleted

@rikinsk rikinsk deleted the console-icons branch July 22, 2020 11:40
rikinsk added a commit to rikinsk/graphql-engine that referenced this pull request Jul 22, 2020
@rikinsk
console: update sidebar icons for different action and trigger types (h…
b474660 
…asura#5445)
rikinsk added a commit that referenced this pull request Jul 22, 2020
@rikinsk
console: update sidebar icons for different action and trigger types (#…
0b972ea 
…5445) (#5447)
stevefan1999-personal pushed a commit to stevefan1999-personal/graphql-engine that referenced this pull request Sep 12, 2020
@rikinsk @stevefan1999-personal
console: update sidebar icons for different action and trigger types (h…
b13749d 
…asura#5445)
@Allymahmoud Allymahmoud mentioned this pull request Oct 14, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tirumaraiselvan tirumaraiselvan tirumaraiselvan approved these changes

+1 more reviewer

@beerose beerose beerose approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@beerose beerose

Labels

c/console Related to console

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rikinsk @hasura-bot @tirumaraiselvan @beerose