这是indexloc提供的服务，不要输入任何密码
Skip to content

console: left-align content on data table #5408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Jul 21, 2020
Merged

console: left-align content on data table #5408

merged 16 commits into from
Jul 21, 2020

Conversation

@kolharsam
Copy link
Contributor

@kolharsam kolharsam commented Jul 17, 2020 •
edited by beerose
Loading

Description

  • Aligns all content on the data table to the left.
  • Makes changes to the way content is aligned in EventTable without using the ReactTable overrides
  • Other minor css fixes and code clean-up.

While testing this out, make sure to check the table present in both Data page and EventTriggers page

Affected components

  • Console

Related Issues

close https://github.com/hasura/graphql-engine-internal/issues/476

@kolharsam kolharsam self-assigned this Jul 17, 2020
@hasura-bot
Copy link
Contributor

hasura-bot commented Jul 17, 2020

Review app for commit 395b191 deployed to Heroku: https://hge-ci-pull-5408.herokuapp.com
Docker image for server: hasura/graphql-engine:pull5408-395b191e

@netlify
Copy link

netlify bot commented Jul 17, 2020 •
edited
Loading

Deploy preview for hasura-docs ready!

Built with commit 1be8572

https://deploy-preview-5408--hasura-docs.netlify.app

@kolharsam kolharsam requested a review from rikinsk July 17, 2020 18:50
@kolharsam kolharsam marked this pull request as ready for review July 17, 2020 18:54
@kolharsam kolharsam requested a review from a team as a code owner July 17, 2020 18:54
@hasura-bot
Copy link
Contributor

hasura-bot commented Jul 17, 2020

Review app for commit 08db62e deployed to Heroku: https://hge-ci-pull-5408.herokuapp.com
Docker image for server: hasura/graphql-engine:pull5408-08db62e4

@hasura-bot
Copy link
Contributor

hasura-bot commented Jul 20, 2020

Review app for commit a9445ee deployed to Heroku: https://hge-ci-pull-5408.herokuapp.com
Docker image for server: hasura/graphql-engine:pull5408-a9445ee9

@beerose beerose assigned rikinsk and unassigned kolharsam and beerose Jul 20, 2020
@hasura-bot
Copy link
Contributor

hasura-bot commented Jul 20, 2020

Review app for commit 1d0ea44 deployed to Heroku: https://hge-ci-pull-5408.herokuapp.com
Docker image for server: hasura/graphql-engine:pull5408-1d0ea44b

rikinsk
rikinsk requested changes Jul 20, 2020
View reviewed changes
Copy link
Member

@rikinsk rikinsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see some columns becoming left aligned in a few events section tables. e.g.
Screenshot from 2020-07-20 17-23-58

In general, this seems to have a lot of changes to achieve the given task. I was expecting a simple css override kind of solution affecting the data browser table only.

By default all react tables can be center aligned. For the data browser table, all columns (except the bulk select and action btns) should be left aligned

@rikinsk rikinsk removed their assignment Jul 20, 2020
@hasura-bot
Copy link
Contributor

hasura-bot commented Jul 20, 2020

Review app for commit 918448e deployed to Heroku: https://hge-ci-pull-5408.herokuapp.com
Docker image for server: hasura/graphql-engine:pull5408-918448e5

@rikinsk rikinsk added this to the v1.3 milestone Jul 20, 2020
@hasura-bot
Copy link
Contributor

hasura-bot commented Jul 20, 2020

Review app for commit 0013c53 deployed to Heroku: https://hge-ci-pull-5408.herokuapp.com
Docker image for server: hasura/graphql-engine:pull5408-0013c53a

@kolharsam kolharsam requested review from beerose and rikinsk July 21, 2020 12:07
@hasura-bot
Copy link
Contributor

hasura-bot commented Jul 21, 2020

Review app for commit 3aae5a6 deployed to Heroku: https://hge-ci-pull-5408.herokuapp.com
Docker image for server: hasura/graphql-engine:pull5408-3aae5a6e

@hasura-bot
Copy link
Contributor

hasura-bot commented Jul 21, 2020

Review app for commit d2317cb deployed to Heroku: https://hge-ci-pull-5408.herokuapp.com
Docker image for server: hasura/graphql-engine:pull5408-d2317cb1

@hasura-bot
Copy link
Contributor

hasura-bot commented Jul 21, 2020

Review app for commit ff097c6 deployed to Heroku: https://hge-ci-pull-5408.herokuapp.com
Docker image for server: hasura/graphql-engine:pull5408-ff097c68

@beerose beerose merged commit ca65035 into hasura:master Jul 21, 2020
@hasura-bot
Copy link
Contributor

hasura-bot commented Jul 21, 2020

Review app https://hge-ci-pull-5408.herokuapp.com is deleted

beerose pushed a commit to beerose/graphql-engine that referenced this pull request Jul 21, 2020
console: left-align content on data table (hasura#5408)
b3f1150
rikinsk pushed a commit that referenced this pull request Jul 21, 2020
console: misc fixes (#5346, #5351, #5415, #5427, #5408) (#5435)
c2a7896 
* console: fix custom root field placeholder for insert one mutation (close #5345) (#5346)
* console: fix clear text issue on RawSQL page (#5351)
* console: fix import metadata button text (close #5386) (#5415)
* console: UI updates (#5427)
- Schema page
  - Keep function sections expanded by default
  - Add Know more link for relationships
- Table relationships page
  - Add tooltips / know more links
  - Update add table relationship UI
  - Remote relationships -> remote schema relationships 
  - Make remote relationships UI consistent
- Events pages
  - fix breadcrumbs
  - update scheduled trigger info image
  - add note regarding UTC timezone based events to tooltip for cron triggers
* console: left-align content on data table (#5408)
stevefan1999-personal pushed a commit to stevefan1999-personal/graphql-engine that referenced this pull request Sep 12, 2020
@stevefan1999-personal
console: left-align content on data table (hasura#5408)
718082e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rikinsk rikinsk rikinsk approved these changes

+1 more reviewer

@beerose beerose beerose approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@beerose beerose

Labels

c/console Related to console no-changelog-required

Projects

None yet

Milestone

v1.3

Development

Successfully merging this pull request may close these issues.

4 participants

@kolharsam @hasura-bot @beerose @rikinsk