update console variables and contributing guide (close #517) #538
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karthikvt26
commented
Sep 26, 2018
Contributor
|
Review app available at: https://hge-ci-pull-538.herokuapp.com |
shahidhk
requested changes
Sep 26, 2018
Member
shahidhk
left a comment
There was a problem hiding this comment.
@karthikvt26 Merge CONTRIBUTING.md to README.md and delete the contributing guide. Also, link to the correct section in README from the main contributing file.
console/README.md
Outdated
|
|
||
| Environment variables accepted in `server` mode: | ||
|
|
||
| 1. **PORT**: Configure the port where Hasura console will run locally. |
console/README.md
Outdated
| ``` | ||
| Environment variables accepted in `cli` mode: | ||
| 1. **PORT**: Configure the port where Hasura console will run locally. |
Contributor
|
Review app available at: https://hge-ci-pull-538.herokuapp.com |
Contributor
|
Review app available at: https://hge-ci-pull-538.herokuapp.com |
Contributor
|
Review app available at: https://hge-ci-pull-538.herokuapp.com |
shahidhk
approved these changes
Sep 27, 2018
Member
|
@rakeshkky @0x777 Needs review for the server changes. @praveenweb Needs review for the console changes |
Contributor
|
Review app https://hge-ci-pull-538.herokuapp.com is deleted |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #517
Description
Changes
consoleModevariable templated by HGE toserverand modified console to respect in the same way and adds a patch to continue working with the older HGEsWhat component does this PR affect?
Requires changes from other components? If yes, please mark the components:
Related Issue
Fixes #517
Checklist: