这是indexloc提供的服务，不要输入任何密码
Skip to content

console: fix default option selected when cloning row in data browser (close #5340) #5364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Oct 7, 2020
Merged

console: fix default option selected when cloning row in data browser (close #5340) #5364

merged 13 commits into from
Oct 7, 2020

Conversation

@ShahAnuj2610
Copy link
Contributor

@ShahAnuj2610 ShahAnuj2610 commented Jul 13, 2020 •
edited
Loading

close #5340

Changelog

  • CHANGELOG.md is updated with user-facing content relevant to this PR. If no changelog is required, then add the no-changelog-required label.

Affected components

  • Console

Solution and Design

  • check if it's a clone action and remove default radio for fields which have values excluding timestamp, uuid and disabled fields (e.g. auto increment)

Steps to test and verify

  • tried cloning the row, inclusive of the above fields

Limitations, known bugs & workarounds

  • as per my knowledge, timestamp, uuid and disabled fields (auto increment) are the fields which should have default selected even when cloning.
  • There could be other fields like above which I might have missed.

@ShahAnuj2610 ShahAnuj2610 requested a review from a team as a code owner July 13, 2020 12:14
@hasura-bot
Copy link
Contributor

hasura-bot commented Jul 13, 2020

Beep boop! 🤖

Hey @ShahAnuj2610, thanks for your PR!

One of my human friends will review this PR and get back to you as soon as possible.

Stay awesome! 😎

@ShahAnuj2610 ShahAnuj2610 requested a review from a team as a code owner July 13, 2020 12:21
@hasura-bot
Copy link
Contributor

hasura-bot commented Jul 22, 2020

Review app for commit dcdb515 deployed to Heroku: https://hge-ci-pull-5364.herokuapp.com
Docker image for server: hasura/graphql-engine:pull5364-dcdb515d

1 similar comment
@hasura-bot
Copy link
Contributor

hasura-bot commented Jul 23, 2020

Review app for commit dcdb515 deployed to Heroku: https://hge-ci-pull-5364.herokuapp.com
Docker image for server: hasura/graphql-engine:pull5364-dcdb515d

@hasura-bot
Copy link
Contributor

hasura-bot commented Jul 23, 2020

Review app for commit b378f8b deployed to Heroku: https://hge-ci-pull-5364.herokuapp.com
Docker image for server: hasura/graphql-engine:pull5364-b378f8b3

soorajshankar
soorajshankar previously requested changes Jul 30, 2020
View reviewed changes
Copy link
Member

@soorajshankar soorajshankar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ShahAnuj2610 for the PR!

Left a few code review comments, please fix that.

@hasura-bot
Copy link
Contributor

hasura-bot commented Jul 30, 2020

Review app for commit 86b4810 deployed to Heroku: https://hge-ci-pull-5364.herokuapp.com
Docker image for server: hasura/graphql-engine:pull5364-86b48107

beerose
beerose suggested changes Aug 3, 2020
View reviewed changes
console/src/components/Services/Data/Common/Components/TableRow.tsx Outdated
!['uuid', 'timestamptz'].includes(col.udt_name):
columnValueType = 'value';
break;
case !isEditing && (isIdentity || hasDefault || isGenerated):
Copy link
Contributor

@beerose beerose Aug 3, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can simplify it.
Instead of adding another case we can handle it along with the first case as:

case !isEditing && !clone && (isIdentity || hasDefault || isGenerated):

Notice added !clone part.

@beerose
Copy link
Contributor

beerose commented Aug 21, 2020

Hi @ShahAnuj2610! I hope you're doing well. I just wanted to ask if you plan to continue working on this PR? 🙂

@ShahAnuj2610
Copy link
Contributor Author

ShahAnuj2610 commented Aug 22, 2020

Hi @ShahAnuj2610! I hope you're doing well. I just wanted to ask if you plan to continue working on this PR? 🙂

Hey @beerose. I'm a little busy these days. I'll make sure to review the changes requested and get back.

beerose
beerose reviewed Sep 12, 2020
View reviewed changes
@netlify
Copy link

netlify bot commented Sep 12, 2020 •
edited
Loading

Deploy preview for hasura-docs ready!

Built with commit bd1a204

https://deploy-preview-5364--hasura-docs.netlify.app

@beerose beerose requested review from soorajshankar and removed request for soorajshankar September 12, 2020 17:45
beerose
beerose approved these changes Sep 12, 2020
View reviewed changes
Copy link
Contributor

@beerose beerose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Console changes.

@beerose beerose requested a review from rikinsk September 14, 2020 07:52
tirumaraiselvan
tirumaraiselvan approved these changes Oct 1, 2020
View reviewed changes
Copy link
Contributor

@tirumaraiselvan tirumaraiselvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no cl required

@beerose beerose assigned beerose and unassigned rikinsk Oct 7, 2020
@beerose beerose dismissed soorajshankar’s stale review October 7, 2020 18:49

Changes were addressed

@beerose beerose merged commit 8bca587 into hasura:master Oct 7, 2020
@hasura-bot
Copy link
Contributor

hasura-bot commented Oct 7, 2020

Beep boop! 🤖

GIF

Awesome work @ShahAnuj2610! All of us at Hasura ❤️ what you did.

Thanks again 🤗

beerose pushed a commit to beerose/graphql-engine that referenced this pull request Nov 10, 2020
@ShahAnuj2610
console: fix default option selected when cloning row in data browser (…
6242cbc 
…close hasura#5340) (hasura#5364)
@beerose beerose mentioned this pull request Nov 10, 2020
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tirumaraiselvan tirumaraiselvan tirumaraiselvan approved these changes

@soorajshankar soorajshankar Awaiting requested review from soorajshankar

@rikinsk rikinsk Awaiting requested review from rikinsk

+1 more reviewer

@beerose beerose beerose approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@beerose beerose

Labels

c/console Related to console community-contrib 🙏🏽 no-changelog-required

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

default option is selected while cloning row in data browser

6 participants

@ShahAnuj2610 @hasura-bot @beerose @soorajshankar @tirumaraiselvan @rikinsk