respect retry-after header on event trigger response #525

tirumaraiselvan · 2018-09-24T12:12:39Z

Description

Webhooks will be retried if responses contain a "Retry-After" header. This will augment the existing RetryConf settings by retrying even if 1) num_retries have been exhausted , 2) Retry-After is smaller than interval_sec

What component does this PR affect?

Requires changes from other components? If yes, please mark the components:

Related Issue

Solution and Design

Changes [(HeaderName, HeaderValue)] -> [EventHeaderInfo] in schema cache
Stores request and response headers in invocation logs
Checks for Retry-After header
Changes HTTPStatus error type from HStatus status resp -> HStatus HTTPResp
Some cleanup

Tests

Type

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

I have read the contributing guide and my code conforms to the guidelines.
This change requires a change in the documentation.
I have updated the documentation accordingly.

0x777 · 2018-09-24T12:30:28Z

server/src-lib/Hasura/Events/Lib.hs

+  }
+$(deriveToJSON (aesonDrop 4 snakeCase){omitNothingFields=True} ''InvocationRequest)
+
+data InvocationResponse


Invocation -> Webhook

server/src-lib/Hasura/Events/Lib.hs

0x777 · 2018-09-24T12:33:19Z

server/src-lib/Hasura/Events/Lib.hs

+    getRetryAfterHeaderFromError (HStatus resp) = getRetryAfterHeaderFromResp resp
+    getRetryAfterHeaderFromError _ = Nothing
+
+    getRetryAfterHeaderFromResp resp = let mHeader = find (\(HeaderConf name _) -> CI.mk name == retryAfterHeader) (hrsHeaders resp)


indentation

0x777 · 2018-09-24T12:45:45Z

server/src-lib/Hasura/Events/Lib.hs

      in  (name, value)

+    decodeHeader :: [EventHeaderInfo] -> (N.HeaderName, BS.ByteString) -> HeaderConf
+    decodeHeader headerInfos (hdrName, hdrVal) = let name = decodeBS $ CI.original hdrName


indentation

hasura-bot · 2018-09-24T12:46:37Z

Review app available at: https://hge-ci-pull-525.herokuapp.com

0x777 · 2018-09-24T12:49:46Z

server/src-lib/Hasura/RQL/Types/Subscribe.hs

 data HeaderValue = HVValue T.Text | HVEnv T.Text
   deriving (Show, Eq, Lift)

+instance ToJSON HeaderValue where


This instance should not exist

…hookResponse

server/src-lib/Hasura/Events/Lib.hs

hasura-bot · 2018-09-24T13:36:12Z

Review app available at: https://hge-ci-pull-525.herokuapp.com

hasura-bot · 2018-09-26T11:23:47Z

Review app available at: https://hge-ci-pull-525.herokuapp.com

hasura-bot · 2018-09-26T11:57:19Z

Review app available at: https://hge-ci-pull-525.herokuapp.com

hasura-bot · 2018-09-26T12:10:53Z

Review app available at: https://hge-ci-pull-525.herokuapp.com

hasura-bot · 2018-09-26T12:20:28Z

Review app available at: https://hge-ci-pull-525.herokuapp.com

shahidhk · 2018-09-26T12:44:28Z

@tirumaraiselvan can you add an appropriate PR title and description please?

hasura-bot · 2018-10-05T10:28:50Z

Review app available at: https://hge-ci-pull-525.herokuapp.com

tirumaraiselvan · 2018-10-17T12:01:40Z

@karthikvt26 Requires console changes to handle new schema of event invocation logs.

# Conflicts: # server/src-lib/Hasura/RQL/DDL/Schema/Table.hs

…gine into retry_after_2

hasura-bot · 2018-10-26T11:24:36Z

Review app available at: https://hge-ci-pull-525.herokuapp.com

…asura#525

hasura-bot · 2018-10-26T15:11:40Z

Review app available at: https://hge-ci-pull-525.herokuapp.com

hasura-bot · 2018-10-26T16:27:25Z

Review app available at: https://hge-ci-pull-525.herokuapp.com

hasura-bot · 2018-10-26T16:28:06Z

Review app https://hge-ci-pull-525.herokuapp.com is deleted

cloudflare-workers-and-pages · 2022-07-20T16:37:04Z

Deploying with Cloudflare Pages

Latest commit:	`aaf9783`
Status:	⚡️ Build in progress...

View logs

The massive `Error` enum from `execute.rs` disintegrates into the following independent error types. - `RequestError`: All exceptions occurred before executing the root field plans. Each variant in this error enum contains the error type stemming from isolated steps in the pipeline involving parsing, validation, IR conversion, and plan generation. - `FieldError`: Exception occurred when resolving a field through its plan. Multiple root fields are executed isolated, and field errors are collected in a list. Code paths for `explain` and `execute` query are split into two functions. This is done to avoid few error variants and unburden the function that previously does both. V3_GIT_ORIGIN_REV_ID: 21f2f43ee4805a955fa0ce7d9b45c4b1902def63

tirumaraiselvan added 4 commits September 24, 2018 17:38

store headers with request and response in invocation logs

4e98a77

check for Retry-After header and reschedule if necessary

f662aa6

no-op cleanup

019a69c

store header info including header type in schema cache

d314d63

0x777 reviewed Sep 24, 2018

View reviewed changes

server/src-lib/Hasura/Events/Lib.hs Show resolved Hide resolved

0x777 reviewed Sep 24, 2018

View reviewed changes

Rename InvocationRequest -> WebhookRequest, InvocationResponse -> Web…

5a72b25

…hookResponse

tirumaraiselvan force-pushed the retry_after_2 branch from 3daa7ca to 5a72b25 Compare September 24, 2018 13:15

tirumaraiselvan commented Sep 24, 2018

View reviewed changes

server/src-lib/Hasura/Events/Lib.hs Show resolved Hide resolved

make response as sumtype with webhook response and init error

69c0e17

tirumaraiselvan added 3 commits September 26, 2018 16:56

Use HeaderConf in EventHeaderInfo instead of explicit types

bc0c810

add version in request and response to avoid catalog change

4f89e67

check for initErrors only instead of all errors

8c781f4

no-op rename

4e98a92

shahidhk added the c/server Related to server label Sep 26, 2018

tirumaraiselvan changed the title ~~Retry after~~ Retry event trigger if "Retry-After" header is found in response Sep 26, 2018

shahidhk added the s/do-not-merge Do not merge this pull request to master label Oct 2, 2018

tirumaraiselvan removed the s/do-not-merge Do not merge this pull request to master label Oct 5, 2018

Merge branch 'master' into retry_after_2

1342152

tirumaraiselvan added the s/do-not-merge Do not merge this pull request to master label Oct 17, 2018

karthikvt26 assigned arvi3411301 Oct 17, 2018

arvi3411301 and others added 3 commits October 26, 2018 15:56

Patches invocation logs section to work with hasura#525

c2a301b

Merge branch 'master' into retry_after_2

abe9ca4

# Conflicts: # server/src-lib/Hasura/RQL/DDL/Schema/Table.hs

Merge branch 'retry_after_2' of github.com:tirumaraiselvan/graphql-en…

fc60792

…gine into retry_after_2

Patches invocation logs section in processed events tab to work with h…

3edae93

…asura#525

arvi3411301 added the c/console Related to console label Oct 26, 2018

Merge branch 'master' into retry_after_2

40f9890

shahidhk changed the title ~~Retry event trigger if "Retry-After" header is found in response~~ respect retry-after header on event trigger response Oct 26, 2018

shahidhk approved these changes Oct 26, 2018

View reviewed changes

shahidhk merged commit baf7c49 into hasura:master Oct 26, 2018

jpda mentioned this pull request May 12, 2022

[Snyk] Upgrade cloudinary from 1.13.2 to 1.29.1 jpda/graphql-engine#3

Open

respect retry-after header on event trigger response #525

respect retry-after header on event trigger response #525

Uh oh!

Conversation

tirumaraiselvan commented Sep 24, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related Issue

Solution and Design

Tests

Type

Checklist:

Uh oh!

0x777 Sep 24, 2018

Choose a reason for hiding this comment

Uh oh!

Uh oh!

0x777 Sep 24, 2018

Choose a reason for hiding this comment

Uh oh!

0x777 Sep 24, 2018

Choose a reason for hiding this comment

Uh oh!

hasura-bot commented Sep 24, 2018

Uh oh!

0x777 Sep 24, 2018

Choose a reason for hiding this comment

Uh oh!

Uh oh!

hasura-bot commented Sep 24, 2018

Uh oh!

hasura-bot commented Sep 26, 2018

Uh oh!

hasura-bot commented Sep 26, 2018

Uh oh!

hasura-bot commented Sep 26, 2018

Uh oh!

hasura-bot commented Sep 26, 2018

Uh oh!

shahidhk commented Sep 26, 2018

Uh oh!

hasura-bot commented Oct 5, 2018

Uh oh!

tirumaraiselvan commented Oct 17, 2018

Uh oh!

hasura-bot commented Oct 26, 2018

Uh oh!

hasura-bot commented Oct 26, 2018

Uh oh!

hasura-bot commented Oct 26, 2018

Uh oh!

hasura-bot commented Oct 26, 2018

Uh oh!

cloudflare-workers-and-pages bot commented Jul 20, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Deploying with Cloudflare Pages

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

tirumaraiselvan commented Sep 24, 2018 •

edited

Loading

cloudflare-workers-and-pages bot commented Jul 20, 2022 •

edited

Loading