Fix column type dropdown #5244
Closed
Fix column type dropdown #5244
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Beep boop! 🤖 Hey @EmrysMyrddin, thanks for your PR! One of my human friends will review this PR and get back to you as soon as possible. Stay awesome! 😎 |
2 tasks
Contributor
|
Review app https://hge-ci-pull-5244.herokuapp.com is deleted |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #5241
Description
Changelog
CHANGELOG.mdis updated with user-facing content relevant to this PR. If no changelog is required, then add theno-changelog-requiredlabel.Affected components
Related Issues
Has an impact on the feature developed in #4546
Solution and Design
The problem comes from the implementation of isCreatable option in the SearchableSelect.
To avoid the complexity of building this behaviour from scratch, I am upgrading
react-selectwhich already has a component for this.Steps to test and verify
I haven't totally understood the
arraypart of #4546, so someone should test I haven't break anythingLimitations, known bugs & workarounds
Breaking changes