这是indexloc提供的服务，不要输入任何密码
Skip to content

console: add button to cancel one-off scheduled events and cron-trigger events (close #5161) #5236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 36 commits into from
Jul 2, 2020
Merged

console: add button to cancel one-off scheduled events and cron-trigger events (close #5161) #5236

merged 36 commits into from
Jul 2, 2020

Conversation

@kolharsam
Copy link
Contributor

@kolharsam kolharsam commented Jun 30, 2020

resolves #5161

Description

The pending events on Cron Triggers and One-off Scheduled Events can now be cancelled using the cancel button situated in the newly added actions column.

Changelog

  • CHANGELOG.md is updated with user-facing content relevant to this PR. If no changelog is required, then add the no-changelog-required label.

Affected components

  • Console

@kolharsam kolharsam added the c/console Related to console label Jun 30, 2020
@kolharsam kolharsam self-assigned this Jun 30, 2020
kolharsam
kolharsam commented Jun 30, 2020
View reviewed changes
Copy link
Contributor Author

@kolharsam kolharsam left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@beerose could you also give it a quick view and provide some comments?

@kolharsam kolharsam changed the title console: add button to cancel one-off scheduled events and cron-trigger events (closes #5161) console: add button to cancel one-off scheduled events and cron-trigger events (close #5161) Jun 30, 2020
@hasura-bot
Copy link
Contributor

hasura-bot commented Jun 30, 2020

Review app for commit 834f9e5 deployed to Heroku: https://hge-ci-pull-5236.herokuapp.com
Docker image for server: hasura/graphql-engine:pull5236-834f9e56

@kolharsam kolharsam marked this pull request as ready for review June 30, 2020 16:02
@kolharsam kolharsam requested review from a team as code owners June 30, 2020 16:02
kolharsam
kolharsam commented Jun 30, 2020
View reviewed changes
Copy link
Contributor Author

@kolharsam kolharsam left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the one small change. But otherwise, the code looks fine.

@hasura-bot
Copy link
Contributor

hasura-bot commented Jun 30, 2020

Review app for commit f68e15b deployed to Heroku: https://hge-ci-pull-5236.herokuapp.com
Docker image for server: hasura/graphql-engine:pull5236-f68e15ba

@hasura-bot
Copy link
Contributor

hasura-bot commented Jun 30, 2020

Review app for commit 5abe9f0 deployed to Heroku: https://hge-ci-pull-5236.herokuapp.com
Docker image for server: hasura/graphql-engine:pull5236-5abe9f03

tirumaraiselvan
tirumaraiselvan reviewed Jul 1, 2020
View reviewed changes
@hasura-bot
Copy link
Contributor

hasura-bot commented Jul 1, 2020

Review app for commit df232c9 deployed to Heroku: https://hge-ci-pull-5236.herokuapp.com
Docker image for server: hasura/graphql-engine:pull5236-df232c93

beerose
beerose suggested changes Jul 1, 2020
View reviewed changes
Copy link
Contributor

@beerose beerose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leaving some laconic comments, as it was discussed in more details over a call.

Key points:

  1. Don't pass dispatch to every component — pass single actions.
  2. Don't mix Redux with UI components.
  3. Use requestAction.

tirumaraiselvan
tirumaraiselvan approved these changes Jul 1, 2020
View reviewed changes
Copy link
Contributor

@tirumaraiselvan tirumaraiselvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changelog

@rikinsk
Copy link
Member

rikinsk commented Jul 1, 2020

/heroku deploy

@hasura-bot
Copy link
Contributor

hasura-bot commented Jul 1, 2020

Review app for commit 5d57723 deployed to Heroku: https://hge-ci-pull-5236.herokuapp.com
Docker image for server: hasura/graphql-engine:pull5236-5d577235

rikinsk
rikinsk requested changes Jul 1, 2020
View reviewed changes
Copy link
Member

@rikinsk rikinsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me overall. Just a small update to the confirmation msgs would be nice:

For cron events: This will delete the "<triggerName>" cron event "<event_id>" scheduled for "<time>"
For one-off events: This will delete the one-off event "<event_id>" scheduled for "<time>"

@rikinsk rikinsk removed their assignment Jul 1, 2020
@kolharsam kolharsam requested a review from rikinsk July 1, 2020 12:34
@hasura-bot
Copy link
Contributor

hasura-bot commented Jul 1, 2020

Review app for commit 6b3bdce deployed to Heroku: https://hge-ci-pull-5236.herokuapp.com
Docker image for server: hasura/graphql-engine:pull5236-6b3bdce0

beerose
beerose reviewed Jul 1, 2020
View reviewed changes
@hasura-bot
Copy link
Contributor

hasura-bot commented Jul 1, 2020

Review app for commit 6b3a58a deployed to Heroku: https://hge-ci-pull-5236.herokuapp.com
Docker image for server: hasura/graphql-engine:pull5236-6b3a58ae

beerose
beerose approved these changes Jul 1, 2020
View reviewed changes
Copy link
Contributor

@beerose beerose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Console changes.

@hasura-bot
Copy link
Contributor

hasura-bot commented Jul 1, 2020

Review app for commit 2efb867 deployed to Heroku: https://hge-ci-pull-5236.herokuapp.com
Docker image for server: hasura/graphql-engine:pull5236-2efb8678

@beerose beerose assigned rikinsk and unassigned kolharsam and beerose Jul 1, 2020
@hasura-bot
Copy link
Contributor

hasura-bot commented Jul 1, 2020

Review app for commit 595fb44 deployed to Heroku: https://hge-ci-pull-5236.herokuapp.com
Docker image for server: hasura/graphql-engine:pull5236-595fb445

@hasura-bot
Copy link
Contributor

hasura-bot commented Jul 2, 2020

Review app for commit 5015fac deployed to Heroku: https://hge-ci-pull-5236.herokuapp.com
Docker image for server: hasura/graphql-engine:pull5236-5015fac2

@rikinsk rikinsk merged commit 6cd9eb2 into hasura:master Jul 2, 2020
@hasura-bot
Copy link
Contributor

hasura-bot commented Jul 2, 2020

Review app https://hge-ci-pull-5236.herokuapp.com is deleted

@tirumaraiselvan tirumaraiselvan mentioned this pull request Jul 2, 2020
Closed
stevefan1999-personal pushed a commit to stevefan1999-personal/graphql-engine that referenced this pull request Sep 12, 2020
@stevefan1999-personal
console: add button to cancel one-off scheduled events and cron-trigg…
3a7b6a2 
…er events (close hasura#5161) (hasura#5236)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tirumaraiselvan tirumaraiselvan tirumaraiselvan approved these changes

@rikinsk rikinsk rikinsk approved these changes

+1 more reviewer

@beerose beerose beerose approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@rikinsk rikinsk

Labels

c/console Related to console

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[v1.3.0-beta.2] Cannot cancel pending one-off scheduled event

5 participants

@kolharsam @hasura-bot @rikinsk @tirumaraiselvan @beerose