这是indexloc提供的服务，不要输入任何密码
Skip to content

fix introspection faling when multiple actions defined with PG scalar types (fix #5166) #5173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 23, 2020
Merged

fix introspection faling when multiple actions defined with PG scalar types (fix #5166) #5173

merged 5 commits into from
Jun 23, 2020

Conversation

@rakeshkky
Copy link
Member

@rakeshkky rakeshkky commented Jun 22, 2020 •
edited
Loading

Description

Introspection query is failing with type info not found for xxxx error message if multiple actions are defined with reused PG scalars. The PR fixes the same.

Changelog

  • CHANGELOG.md is updated with user-facing content relevant to this PR. If no changelog is required, then add the no-changelog-required label.

Affected components

  • Server
  • Tests

Related Issues

Fix #5166

Solution and Design

See the in line diff comment.

Steps to test and verify

Define more than one actions with PG scalars. The introspection query should go through and schema should be shown in the graphiql docs.

Limitations, known bugs & workarounds

NA

Server checklist

Catalog upgrade

Does this PR change Hasura Catalog version?

  • No
  • Yes

Metadata

Does this PR add a new Metadata feature?

  • No
  • Yes

GraphQL

  • No new GraphQL schema is generated
  • New GraphQL schema is being generated

Breaking changes

  • No Breaking changes
  • There are breaking changes

@rakeshkky rakeshkky added c/server Related to server c/actions Related to actions labels Jun 22, 2020
@rakeshkky rakeshkky self-assigned this Jun 22, 2020
rakeshkky
rakeshkky commented Jun 22, 2020
View reviewed changes
server/src-lib/Hasura/GraphQL/Schema/Action.hs
, foldr addScalarToTyAgg mempty $
pgScalars <> Set.fromList [PGJSON, PGTimeStampTZ, PGUUID]
, foldr addScalarToTyAgg mempty [PGJSON, PGTimeStampTZ, PGUUID]
)
Copy link
Member Author

@rakeshkky rakeshkky Jun 22, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This function is causing the issue. The mkNewRoleState function initiates the state with empty RootFields and TyAgg with PG scalars reused and mandatory scalars for actions. This function is invoked only for the first action in the list (unfortunately) and remaining actions' reused PG scalars were not added to TyAgg. Hence the issue only exist if multiple actions are defined. The fix is to remove adding PG scalars in this function and add PG scalars to TyAgg explicitly for each action in accumulate functions.

@hasura-bot
Copy link
Contributor

hasura-bot commented Jun 22, 2020

Review app for commit a379bfc deployed to Heroku: https://hge-ci-pull-5173.herokuapp.com
Docker image for server: hasura/graphql-engine:pull5173-a379bfc1

@hasura-bot
Copy link
Contributor

hasura-bot commented Jun 22, 2020

Review app for commit 29445f5 deployed to Heroku: https://hge-ci-pull-5173.herokuapp.com
Docker image for server: hasura/graphql-engine:pull5173-29445f51

@rakeshkky rakeshkky force-pushed the 5166-action-introspection-fix branch from a5e4284 to 21123c7 Compare June 23, 2020 06:57
@rakeshkky rakeshkky changed the title fix introspection faling if multiple actions using PG scalar types (fix #5166) fix introspection faling when multiple actions defined with PG scalar types (fix #5166) Jun 23, 2020
@rakeshkky rakeshkky force-pushed the 5166-action-introspection-fix branch from 21123c7 to 4a427ca Compare June 23, 2020 06:58
@rakeshkky rakeshkky marked this pull request as ready for review June 23, 2020 06:59
@rakeshkky rakeshkky requested a review from a team as a code owner June 23, 2020 06:59
tirumaraiselvan
tirumaraiselvan approved these changes Jun 23, 2020
View reviewed changes
Copy link
Contributor

@tirumaraiselvan tirumaraiselvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CL approved

@hasura-bot
Copy link
Contributor

hasura-bot commented Jun 23, 2020

Review app for commit 4a427ca deployed to Heroku: https://hge-ci-pull-5173.herokuapp.com
Docker image for server: hasura/graphql-engine:pull5173-4a427cad

0x777
0x777 approved these changes Jun 23, 2020
View reviewed changes
Copy link
Member

@0x777 0x777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

codingkarthik
codingkarthik approved these changes Jun 23, 2020
View reviewed changes
Copy link
Contributor

@codingkarthik codingkarthik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hasura-bot
Copy link
Contributor

hasura-bot commented Jun 23, 2020

Review app for commit 583dd54 deployed to Heroku: https://hge-ci-pull-5173.herokuapp.com
Docker image for server: hasura/graphql-engine:pull5173-583dd541

@rakeshkky rakeshkky merged commit ea23571 into hasura:master Jun 23, 2020
@hasura-bot
Copy link
Contributor

hasura-bot commented Jun 23, 2020

Review app https://hge-ci-pull-5173.herokuapp.com is deleted

rakeshkky added a commit to lexi-lambda/graphql-engine that referenced this pull request Jul 20, 2020
@rakeshkky
[skip ci] fix introspection faling when multiple actions defined with…
0f9dd6b 
… PG scalar types (fix hasura#5166) (hasura#5173)

Introspection query is failing with `type info not found for xxxx` error message if multiple actions are defined with reused PG scalars. The fix for the same.
stevefan1999-personal pushed a commit to stevefan1999-personal/graphql-engine that referenced this pull request Sep 12, 2020
@rakeshkky @stevefan1999-personal
fix introspection faling when multiple actions defined with PG scalar…
dabd966 
… types (fix hasura#5166) (hasura#5173)

Introspection query is failing with `type info not found for xxxx` error message if multiple actions are defined with reused PG scalars. The fix for the same.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@0x777 0x777 0x777 approved these changes

@tirumaraiselvan tirumaraiselvan tirumaraiselvan approved these changes

@codingkarthik codingkarthik codingkarthik approved these changes

Assignees

@rakeshkky rakeshkky

Labels

c/actions Related to actions c/server Related to server

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Actions causing introspection to break

5 participants

@rakeshkky @hasura-bot @0x777 @tirumaraiselvan @codingkarthik