这是indexloc提供的服务，不要输入任何密码
Skip to content

cli: when applying metadata, assume empty metadata plugin files if they don't exist (close #5163) #5170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
Jun 24, 2020
Merged

cli: when applying metadata, assume empty metadata plugin files if they don't exist (close #5163) #5170

merged 17 commits into from
Jun 24, 2020

Conversation

@scriptonist
Copy link
Contributor

@scriptonist scriptonist commented Jun 22, 2020

Description

  • CLI throws an error when a file required by a metadata plugin is not found. For example for the cron_triggers metadata plugin, it requires a cron_triggers.yaml file to work. This PR will change this behaviour and assume an empty file when the required file is not found.

Changelog

  • CHANGELOG.md is updated with user-facing content relevant to this PR. If no changelog is required, then add the no-changelog-required label.

Affected components

  • CLI

Related Issues

close #5163

@scriptonist scriptonist added the c/cli Related to CLI label Jun 22, 2020
@hasura-bot
Copy link
Contributor

hasura-bot commented Jun 22, 2020

Review app for commit ec4a499 deployed to Heroku: https://hge-ci-pull-5170.herokuapp.com
Docker image for server: hasura/graphql-engine:pull5170-ec4a4991

@hasura-bot
Copy link
Contributor

hasura-bot commented Jun 22, 2020

Review app for commit 6569004 deployed to Heroku: https://hge-ci-pull-5170.herokuapp.com
Docker image for server: hasura/graphql-engine:pull5170-65690048

@scriptonist scriptonist marked this pull request as ready for review June 23, 2020 02:31
@scriptonist scriptonist requested review from a team as code owners June 23, 2020 02:31
@netlify
Copy link

netlify bot commented Jun 23, 2020

Deploy preview for hasura-docs ready!

Built with commit 490aaa6

https://deploy-preview-5170--hasura-docs.netlify.app

@netlify
Copy link

netlify bot commented Jun 23, 2020 •
edited
Loading

Deploy preview for hasura-docs ready!

Built with commit 864af26

https://deploy-preview-5170--hasura-docs.netlify.app

@hasura-bot
Copy link
Contributor

hasura-bot commented Jun 23, 2020

Review app for commit ce3c60e deployed to Heroku: https://hge-ci-pull-5170.herokuapp.com
Docker image for server: hasura/graphql-engine:pull5170-ce3c60e1

@hasura-bot
Copy link
Contributor

hasura-bot commented Jun 23, 2020

Review app for commit e3a654c deployed to Heroku: https://hge-ci-pull-5170.herokuapp.com
Docker image for server: hasura/graphql-engine:pull5170-e3a654c7

@hasura-bot
Copy link
Contributor

hasura-bot commented Jun 23, 2020

Review app for commit 4b42cc3 deployed to Heroku: https://hge-ci-pull-5170.herokuapp.com
Docker image for server: hasura/graphql-engine:pull5170-4b42cc31

tirumaraiselvan
tirumaraiselvan reviewed Jun 23, 2020
View reviewed changes
@hasura-bot
Copy link
Contributor

hasura-bot commented Jun 23, 2020

Review app for commit d91cff9 deployed to Heroku: https://hge-ci-pull-5170.herokuapp.com
Docker image for server: hasura/graphql-engine:pull5170-d91cff97

@hasura-bot
Copy link
Contributor

hasura-bot commented Jun 23, 2020

Review app for commit 161a690 deployed to Heroku: https://hge-ci-pull-5170.herokuapp.com
Docker image for server: hasura/graphql-engine:pull5170-161a690c

@scriptonist @tirumaraiselvan
Update CHANGELOG.md
dcd8835 
Co-authored-by: Tirumarai Selvan <tirumarai.selvan@gmail.com>
@hasura-bot
Copy link
Contributor

hasura-bot commented Jun 23, 2020

Review app for commit dcd8835 deployed to Heroku: https://hge-ci-pull-5170.herokuapp.com
Docker image for server: hasura/graphql-engine:pull5170-dcd8835b

jflambert
jflambert reviewed Jun 23, 2020
View reviewed changes
@scriptonist @jflambert
Update cli/migrate/database/hasuradb/metadata.go
864af26 
Co-authored-by: jflambert <jflambert@users.noreply.github.com>
@hasura-bot
Copy link
Contributor

hasura-bot commented Jun 23, 2020

Review app for commit 864af26 deployed to Heroku: https://hge-ci-pull-5170.herokuapp.com
Docker image for server: hasura/graphql-engine:pull5170-864af261

@hasura-bot
Copy link
Contributor

hasura-bot commented Jun 24, 2020

Review app for commit 9812ec7 deployed to Heroku: https://hge-ci-pull-5170.herokuapp.com
Docker image for server: hasura/graphql-engine:pull5170-9812ec7e

@hasura-bot
Copy link
Contributor

hasura-bot commented Jun 24, 2020

Review app for commit 9959758 deployed to Heroku: https://hge-ci-pull-5170.herokuapp.com
Docker image for server: hasura/graphql-engine:pull5170-99597582

tirumaraiselvan
tirumaraiselvan approved these changes Jun 24, 2020
View reviewed changes
Copy link
Contributor

@tirumaraiselvan tirumaraiselvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changelog approved

@scriptonist scriptonist merged commit 6486a4f into hasura:master Jun 24, 2020
@hasura-bot
Copy link
Contributor

hasura-bot commented Jun 24, 2020

Review app https://hge-ci-pull-5170.herokuapp.com is deleted

@scriptonist scriptonist mentioned this pull request Jun 29, 2020
Closed
stevefan1999-personal pushed a commit to stevefan1999-personal/graphql-engine that referenced this pull request Sep 12, 2020
@scriptonist @stevefan1999-personal
cli: when applying metadata, assume empty metadata plugin files if th…
ddf706f 
…ey don't exist (close hasura#5163) (hasura#5170)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tirumaraiselvan tirumaraiselvan tirumaraiselvan approved these changes

@arvi3411301 arvi3411301 arvi3411301 approved these changes

+1 more reviewer

@jflambert jflambert jflambert left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c/cli Related to CLI

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[v1.3.0-beta.2] Cannot upgrade from v1.2.x.cli-migrations-v2

5 participants

@scriptonist @hasura-bot @tirumaraiselvan @jflambert @arvi3411301