-
Notifications
You must be signed in to change notification settings - Fork 2.8k
fix postgres error when querying object relationship in fields and with in order by clause (fix #5148) #5177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix postgres error when querying object relationship in fields and with in order by clause (fix #5148) #5177
Conversation
|
Deploy preview for hasura-docs ready! Built with commit 148edf3 |
|
Review app for commit 1d8787d deployed to Heroku: https://hge-ci-pull-5177.herokuapp.com |
|
Review app for commit 148edf3 deployed to Heroku: https://hge-ci-pull-5177.herokuapp.com |
|
Review app for commit 943be5c deployed to Heroku: https://hge-ci-pull-5177.herokuapp.com |
|
Review app for commit c05d3c6 deployed to Heroku: https://hge-ci-pull-5177.herokuapp.com |
|
Review app for commit 17b5fec deployed to Heroku: https://hge-ci-pull-5177.herokuapp.com |
|
Review app for commit 47536d1 deployed to Heroku: https://hge-ci-pull-5177.herokuapp.com |
|
Review app https://hge-ci-pull-5177.herokuapp.com is deleted |
…ssion limit, fix hasura#5148 (hasura#5177) Co-authored-by: Tirumarai Selvan <tiru@hasura.io>
fix hasura#5148 (hasura#5177) Co-authored-by: Tirumarai Selvan <tiru@hasura.io>
Description
The issue came from the recent refactor of internal types of
Selectmodules. Any of existing test cases didn't catch it becauseCause: In generated SQL, sub queries for object relationships from same table are grouped together. Unfortunately, this was not happening for object relationships present in order by clause and selection set if any permission limit set. The permission limit was considered into the identifier and hence both order by and selection set object relationship fields are treated different.
Changelog
CHANGELOG.mdis updated with user-facing content relevant to this PR. If no changelog is required, then add theno-changelog-requiredlabel.No changelog required since the bug doesn't exist in previous stable releases.
Affected components
Related Issues
Solution and Design
Refactor object relationship types without considering the permission limits.
Steps to test and verify
Limitations, known bugs & workarounds
Server checklist
Catalog upgrade
Does this PR change Hasura Catalog version?
Metadata
Does this PR add a new Metadata feature?
GraphQL
Breaking changes