take access key from redux state #514
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karthikvt26
commented
Sep 21, 2018
| const mapStateToProps = state => { | ||
| return { | ||
| ...state.main, | ||
| dataHeaders: state.tables.dataHeaders, |
Contributor
Author
There was a problem hiding this comment.
dataHeaders is injected into the prop. @praveenweb
Contributor
|
Review app available at: https://hge-ci-pull-514.herokuapp.com |
Contributor
|
Review app available at: https://hge-ci-pull-514.herokuapp.com |
Member
|
@karthikvt26 @praveenweb Let's make sure we have associated issue next time. |
Contributor
|
Review app https://hge-ci-pull-514.herokuapp.com is deleted |
Deploying with
|
| Latest commit: |
a2ef9eb
|
| Status: | 🚫 Build failed. |
hasura-bot
pushed a commit
that referenced
this pull request
Apr 29, 2024
V3_GIT_ORIGIN_REV_ID: 11e583559b0143e8fa7056a39c98c20fff6bb83e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Metadata tab used to read access key from environment variable since that was the previous flow. We changed it post #481 fix. Now it reads from the redux state.
What component does this PR affect?
Requires changes from other components? If yes, please mark the components:
Related Issue
Solution and Design
The issue is fixed by reading the headers state from the redux state as that is the primary source of information for all the data.
Tests
Type
Checklist: