这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@codingkarthik
Copy link
Contributor

fixes #5103

Description

Changelog

  • CHANGELOG.md is updated with user-facing content relevant to this PR. If no changelog is required, then add the no-changelog-required label.

Affected components

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System
  • Tests
  • Other (list it)

Related Issues

Solution and Design

Steps to test and verify

Limitations, known bugs & workarounds

Server checklist

Catalog upgrade

Does this PR change Hasura Catalog version?

  • No
  • Yes
    • Updated docs with SQL for downgrading the catalog

Metadata

Does this PR add a new Metadata feature?

  • No
  • Yes
    • Does run_sql auto manages the new metadata through schema diffing?
      • Yes
      • Not required
    • Does run_sql auto manages the definitions of metadata on renaming?
      • Yes
      • Not required
    • Does export_metadata/replace_metadata supports the new metadata added?
      • Yes
      • Not required

GraphQL

  • No new GraphQL schema is generated
  • New GraphQL schema is being generated:
    • New types and typenames are correlated

Breaking changes

  • No Breaking changes

  • There are breaking changes:

    1. Metadata API

      Existing query types:

      • Modify args payload which is not backward compatible
      • Behavioural change of the API
      • Change in response JSON schema
      • Change in error code
    2. GraphQL API

      Schema Generation:

      • Change in any NamedType
      • Change in table field names

      Schema Resolve:-

      • Change in treatment of null value for any input fields
    3. Logging

      • Log JSON schema has changed
      • Log type names have changed

@codingkarthik codingkarthik changed the title drop catalog dependencies when parent column/table is dropped drop catalog dependencies when parent column/table is dropped containing a remote relationship Jun 17, 2020
@codingkarthik codingkarthik requested a review from rakeshkky June 17, 2020 06:13
@codingkarthik codingkarthik requested a review from a team as a code owner June 17, 2020 06:15
Copy link
Member

@rakeshkky rakeshkky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Server LGTM

@hasura-bot
Copy link
Contributor

Review app for commit db84bb9 deployed to Heroku: https://hge-ci-pull-5119.herokuapp.com
Docker image for server: hasura/graphql-engine:pull5119-db84bb98

@codingkarthik codingkarthik merged commit d064959 into hasura:master Jun 17, 2020
@hasura-bot
Copy link
Contributor

Review app https://hge-ci-pull-5119.herokuapp.com is deleted

stevefan1999-personal pushed a commit to stevefan1999-personal/graphql-engine that referenced this pull request Sep 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cannot drop column and cascade dependencies if remote relationship is present

4 participants