这是indexloc提供的服务，不要输入任何密码
Skip to content

console: allow configuring statement timeout on console RawSQL page (close #4998) #5045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 41 commits into from
Jul 1, 2020
Merged

console: allow configuring statement timeout on console RawSQL page (close #4998) #5045

merged 41 commits into from
Jul 1, 2020

Conversation

@gokulchandra
Copy link
Contributor

@gokulchandra gokulchandra commented Jun 10, 2020 •
edited
Loading

Description

Allows users to configure statement level timeouts.
More info here #4998

Changelog

  • CHANGELOG.md is updated with user-facing content relevant to this PR.

Affected components

  • Server
  • Console
  • Docs
  • Community Content
  • Tests

Related Issues

#4998

@hasura-bot
Copy link
Contributor

hasura-bot commented Jun 10, 2020

Beep boop! 🤖

Hey @gokulchandra, thanks for your PR!

One of my human friends will review this PR and get back to you as soon as possible.

Stay awesome! 😎

@hasura-bot
Copy link
Contributor

hasura-bot commented Jun 13, 2020

Review app for commit 46cef27 deployed to Heroku: https://hge-ci-pull-5045.herokuapp.com
Docker image for server: hasura/graphql-engine:pull5045-46cef270

@hasura-bot
Copy link
Contributor

hasura-bot commented Jun 14, 2020

Review app for commit f65e179 deployed to Heroku: https://hge-ci-pull-5045.herokuapp.com
Docker image for server: hasura/graphql-engine:pull5045-f65e179f

@gokulchandra gokulchandra mentioned this pull request Jun 14, 2020
Closed
@hasura-bot
Copy link
Contributor

hasura-bot commented Jun 17, 2020

Review app for commit 011f0bd deployed to Heroku: https://hge-ci-pull-5045.herokuapp.com
Docker image for server: hasura/graphql-engine:pull5045-011f0bd7

@gokulchandra gokulchandra marked this pull request as ready for review June 17, 2020 11:07
@gokulchandra gokulchandra requested review from a team as code owners June 17, 2020 11:07
@hasura-bot
Copy link
Contributor

hasura-bot commented Jun 17, 2020

Review app for commit 18243df deployed to Heroku: https://hge-ci-pull-5045.herokuapp.com
Docker image for server: hasura/graphql-engine:pull5045-18243df2

@rikinsk rikinsk self-assigned this Jun 17, 2020
@netlify
Copy link

netlify bot commented Jun 17, 2020 •
edited
Loading

Deploy preview for hasura-docs ready!

Built with commit dbf25b3

https://deploy-preview-5045--hasura-docs.netlify.app

@hasura-bot
Copy link
Contributor

hasura-bot commented Jun 17, 2020

Review app for commit 5fdd796 deployed to Heroku: https://hge-ci-pull-5045.herokuapp.com
Docker image for server: hasura/graphql-engine:pull5045-5fdd7967

@rikinsk
Copy link
Member

rikinsk commented Jun 18, 2020 •
edited
Loading

I resolved conflicts with master and took the liberty to make a couple of minor UI changes.

I also set the default initial value of the timeout as 10 seconds

rikinsk
rikinsk approved these changes Jun 18, 2020
View reviewed changes
Copy link
Member

@rikinsk rikinsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UX approved

@gokulchandra gokulchandra requested a review from beerose June 26, 2020 22:38
@hasura-bot
Copy link
Contributor

hasura-bot commented Jun 26, 2020

Review app for commit ff0a990 deployed to Heroku: https://hge-ci-pull-5045.herokuapp.com
Docker image for server: hasura/graphql-engine:pull5045-ff0a9908

@hasura-bot
Copy link
Contributor

hasura-bot commented Jun 30, 2020

Review app for commit a91befd deployed to Heroku: https://hge-ci-pull-5045.herokuapp.com
Docker image for server: hasura/graphql-engine:pull5045-a91befd2

@hasura-bot
Copy link
Contributor

hasura-bot commented Jul 1, 2020

Review app for commit 3c9cdf6 deployed to Heroku: https://hge-ci-pull-5045.herokuapp.com
Docker image for server: hasura/graphql-engine:pull5045-3c9cdf60

beerose
beerose approved these changes Jul 1, 2020
View reviewed changes
Copy link
Contributor

@beerose beerose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Console changes.

@hasura-bot
Copy link
Contributor

hasura-bot commented Jul 1, 2020

Review app for commit 8ca70c9 deployed to Heroku: https://hge-ci-pull-5045.herokuapp.com
Docker image for server: hasura/graphql-engine:pull5045-8ca70c94

beerose
beerose reviewed Jul 1, 2020
View reviewed changes
Aleksandra Sikora and others added 2 commits July 1, 2020 19:13
beerose
beerose reviewed Jul 1, 2020
View reviewed changes
@beerose beerose changed the title Allow configurable statement timeouts (close #4998) console: allow configuring statement timeout on console RawSQL page (close #4998) Jul 1, 2020
@hasura-bot
Copy link
Contributor

hasura-bot commented Jul 1, 2020

Review app for commit dbf25b3 deployed to Heroku: https://hge-ci-pull-5045.herokuapp.com
Docker image for server: hasura/graphql-engine:pull5045-dbf25b38

tirumaraiselvan
tirumaraiselvan approved these changes Jul 1, 2020
View reviewed changes
Copy link
Contributor

@tirumaraiselvan tirumaraiselvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changelog

@hasura-bot
Copy link
Contributor

hasura-bot commented Jul 1, 2020

Review app for commit 58bc9fd deployed to Heroku: https://hge-ci-pull-5045.herokuapp.com
Docker image for server: hasura/graphql-engine:pull5045-58bc9fd9

@beerose beerose linked an issue Jul 1, 2020 that may be closed by this pull request
add a configurable statement_timeout on console raw sql page #4998
Closed
@beerose beerose merged commit b9918e0 into hasura:master Jul 1, 2020
@hasura-bot
Copy link
Contributor

hasura-bot commented Jul 1, 2020

Review app https://hge-ci-pull-5045.herokuapp.com is deleted

@hasura-bot
Copy link
Contributor

hasura-bot commented Jul 1, 2020

Beep boop! 🤖

GIF

Awesome work @gokulchandra! All of us at Hasura ❤️ what you did.

Thanks again 🤗

@gokulchandra gokulchandra deleted the configure-raw-statement-timeout branch July 1, 2020 23:15
@gokulchandra gokulchandra restored the configure-raw-statement-timeout branch July 1, 2020 23:15
@gokulchandra gokulchandra deleted the configure-raw-statement-timeout branch July 1, 2020 23:15
@gokulchandra gokulchandra restored the configure-raw-statement-timeout branch July 1, 2020 23:15
@marionschleifer
Copy link
Contributor

marionschleifer commented Jul 2, 2020

@gokulchandra thank you for contributing to Hasura 🙏 we'd love to send you some Hasura swag as a thank you. If you're interested, please send an email to marion@hasura.io and we'll take it from there 🙂

stevefan1999-personal pushed a commit to stevefan1999-personal/graphql-engine that referenced this pull request Sep 12, 2020
@gokulchandra @stevefan1999-personal
console: allow configuring statement timeout on console RawSQL page (c…
1647e9f 
…lose hasura#4998) (hasura#5045)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tirumaraiselvan tirumaraiselvan tirumaraiselvan approved these changes

@rikinsk rikinsk rikinsk approved these changes

+1 more reviewer

@beerose beerose beerose approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@beerose beerose

Labels

c/console Related to console community-contrib 🙏🏽

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

add a configurable statement_timeout on console raw sql page

6 participants

@gokulchandra @hasura-bot @rikinsk @beerose @marionschleifer @tirumaraiselvan