这是indexloc提供的服务，不要输入任何密码
Skip to content

cli: add new flags to generate sql migrations (close #5026) #5039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Jun 16, 2020
Merged

cli: add new flags to generate sql migrations (close #5026) #5039

merged 12 commits into from
Jun 16, 2020

Conversation

@kolharsam
Copy link
Contributor

@kolharsam kolharsam commented Jun 10, 2020

Description

A new set of flags are added to the migrate command on the CLI. The up-sql and down-sql flags can be used to create SQL migrations from the CLI. These flags are to be used in conjunction. Either being absent during execution results in an error.

Changelog

  • CHANGELOG.md is updated with user-facing content relevant to this PR. If no changelog is required, then add the no-changelog-required label.

Affected components

  • CLI

Related Issues

resolves #5026

Breaking changes

  • No Breaking changes

@kolharsam kolharsam added the c/cli Related to CLI label Jun 10, 2020
@kolharsam kolharsam requested review from a team as code owners June 10, 2020 05:08
@netlify
Copy link

netlify bot commented Jun 10, 2020 •
edited
Loading

Deploy preview for hasura-docs ready!

Built with commit 6665b82

https://deploy-preview-5039--hasura-docs.netlify.app

tirumaraiselvan
tirumaraiselvan approved these changes Jun 10, 2020
View reviewed changes
Copy link
Contributor

@tirumaraiselvan tirumaraiselvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CL

@hasura-bot
Copy link
Contributor

hasura-bot commented Jun 10, 2020

Review app for commit 1815bea deployed to Heroku: https://hge-ci-pull-5039.herokuapp.com
Docker image for server: hasura/graphql-engine:pull5039-1815bea3

kolharsam
kolharsam commented Jun 10, 2020
View reviewed changes
Copy link
Contributor Author

@kolharsam kolharsam left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no issues found in self-review

scriptonist
scriptonist reviewed Jun 11, 2020
View reviewed changes
@kolharsam kolharsam requested a review from scriptonist June 11, 2020 08:37
@hasura-bot
Copy link
Contributor

hasura-bot commented Jun 11, 2020

Review app for commit e328fee deployed to Heroku: https://hge-ci-pull-5039.herokuapp.com
Docker image for server: hasura/graphql-engine:pull5039-e328fee3

@hasura-bot
Copy link
Contributor

hasura-bot commented Jun 11, 2020

Review app for commit 4550079 deployed to Heroku: https://hge-ci-pull-5039.herokuapp.com
Docker image for server: hasura/graphql-engine:pull5039-45500792

scriptonist
scriptonist reviewed Jun 12, 2020
View reviewed changes
@hasura-bot
Copy link
Contributor

hasura-bot commented Jun 12, 2020

Review app for commit 224a001 deployed to Heroku: https://hge-ci-pull-5039.herokuapp.com
Docker image for server: hasura/graphql-engine:pull5039-224a001a

scriptonist
scriptonist reviewed Jun 15, 2020
View reviewed changes
kolharsam
kolharsam commented Jun 15, 2020
View reviewed changes
Copy link
Contributor Author

@kolharsam kolharsam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reverted previous suggestions and changed acc. to latest suggestions

@kolharsam kolharsam requested a review from scriptonist June 15, 2020 07:53
@scriptonist scriptonist changed the title cli: add new flags to generate sql migrations cli: add new flags to generate sql migrations (close #5026) Jun 16, 2020
@hasura-bot
Copy link
Contributor

hasura-bot commented Jun 16, 2020

Review app for commit a61c1ea deployed to Heroku: https://hge-ci-pull-5039.herokuapp.com
Docker image for server: hasura/graphql-engine:pull5039-a61c1ea4

scriptonist
scriptonist reviewed Jun 16, 2020
View reviewed changes
@hasura-bot
Copy link
Contributor

hasura-bot commented Jun 16, 2020

Review app for commit 6665b82 deployed to Heroku: https://hge-ci-pull-5039.herokuapp.com
Docker image for server: hasura/graphql-engine:pull5039-6665b824

@hasura-bot
Copy link
Contributor

hasura-bot commented Jun 16, 2020

Review app for commit f533cd1 deployed to Heroku: https://hge-ci-pull-5039.herokuapp.com
Docker image for server: hasura/graphql-engine:pull5039-f533cd13

@scriptonist scriptonist merged commit 13e4edb into hasura:master Jun 16, 2020
@hasura-bot
Copy link
Contributor

hasura-bot commented Jun 16, 2020

Review app https://hge-ci-pull-5039.herokuapp.com is deleted

stevefan1999-personal pushed a commit to stevefan1999-personal/graphql-engine that referenced this pull request Sep 12, 2020
@stevefan1999-personal
cli: add flags --up-sql and --down-sql to migrate create command (close
b5dd3f8 
hasura#5026) (hasura#5039)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tirumaraiselvan tirumaraiselvan tirumaraiselvan approved these changes

+1 more reviewer

@scriptonist scriptonist scriptonist approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@scriptonist scriptonist

Labels

c/cli Related to CLI

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

cli: allow passing sql by flag to migrate create

4 participants

@kolharsam @hasura-bot @scriptonist @tirumaraiselvan