这是indexloc提供的服务，不要输入任何密码
Skip to content

cli: fix cron triggers not being exported on a metadata export (close #5047) #5060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Jun 16, 2020
Merged

cli: fix cron triggers not being exported on a metadata export (close #5047) #5060

merged 10 commits into from
Jun 16, 2020

Conversation

@scriptonist
Copy link
Contributor

@scriptonist scriptonist commented Jun 11, 2020

Description

Detailed here

Affected components

  • CLI

Related Issues

#5047

@scriptonist scriptonist added this to the v1.3 milestone Jun 11, 2020
@netlify
Copy link

netlify bot commented Jun 11, 2020

Deploy preview for hasura-docs ready!

Built with commit c55c24b

https://deploy-preview-5060--hasura-docs.netlify.app

@hasura-bot
Copy link
Contributor

hasura-bot commented Jun 11, 2020

Review app for commit 4600664 deployed to Heroku: https://hge-ci-pull-5060.herokuapp.com
Docker image for server: hasura/graphql-engine:pull5060-4600664e

@hasura-bot
Copy link
Contributor

hasura-bot commented Jun 11, 2020

Review app for commit d8cc0c9 deployed to Heroku: https://hge-ci-pull-5060.herokuapp.com
Docker image for server: hasura/graphql-engine:pull5060-d8cc0c9f

@hasura-bot
Copy link
Contributor

hasura-bot commented Jun 11, 2020

Review app for commit 9f654bb deployed to Heroku: https://hge-ci-pull-5060.herokuapp.com
Docker image for server: hasura/graphql-engine:pull5060-9f654bba

@scriptonist scriptonist marked this pull request as ready for review June 11, 2020 07:37
@scriptonist scriptonist requested review from a team as code owners June 11, 2020 07:37
@netlify
Copy link

netlify bot commented Jun 11, 2020 •
edited
Loading

Deploy preview for hasura-docs ready!

Built with commit b5843e4

https://deploy-preview-5060--hasura-docs.netlify.app

@hasura-bot
Copy link
Contributor

hasura-bot commented Jun 11, 2020

Review app for commit 322f458 deployed to Heroku: https://hge-ci-pull-5060.herokuapp.com
Docker image for server: hasura/graphql-engine:pull5060-322f4584

@hasura-bot
Copy link
Contributor

hasura-bot commented Jun 16, 2020

Review app for commit b5843e4 deployed to Heroku: https://hge-ci-pull-5060.herokuapp.com
Docker image for server: hasura/graphql-engine:pull5060-b5843e49

@hasura-bot
Copy link
Contributor

hasura-bot commented Jun 16, 2020

Review app for commit 54b8996 deployed to Heroku: https://hge-ci-pull-5060.herokuapp.com
Docker image for server: hasura/graphql-engine:pull5060-54b89961

@hasura-bot
Copy link
Contributor

hasura-bot commented Jun 16, 2020

Review app for commit 112b896 deployed to Heroku: https://hge-ci-pull-5060.herokuapp.com
Docker image for server: hasura/graphql-engine:pull5060-112b8968

tirumaraiselvan
tirumaraiselvan approved these changes Jun 16, 2020
View reviewed changes
Copy link
Contributor

@tirumaraiselvan tirumaraiselvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CL not required.

@scriptonist scriptonist merged commit 5a648a9 into hasura:master Jun 16, 2020
@hasura-bot
Copy link
Contributor

hasura-bot commented Jun 16, 2020

Review app https://hge-ci-pull-5060.herokuapp.com is deleted

@jflambert
Copy link
Contributor

jflambert commented Jun 22, 2020

I don't see this fix listed in the 1.3.0-beta.2 changelog

@jflambert
Copy link
Contributor

jflambert commented Jun 22, 2020 •
edited
Loading

@scriptonist I'm trying 1.3.0-beta.2 and it's crashing hard upon loading my 1.2.2 v2 metadata

time="2020-06-22T02:08:06Z" level=fatal msg="failed to apply metadata: cannot apply metadata on the database: cannot build cron_triggers from metadata: open /tmp/hasura-project/metadata/cron_triggers.yaml: no such file or directory"

it's fully expecting the file to be present and of course it's not. You should treat it as empty when it's not present or ... I don't know what else, but you will have plenty of people unable to upgrade from 1.2 to 1.3.0

And yes it works when I create a file called cron_triggers.yaml with just [] inside

@scriptonist
Copy link
Contributor Author

scriptonist commented Jun 22, 2020 •
edited
Loading

Hey @jflambert , that's concerning. Just wanted to gather a bit more info.

  1. You upgraded your server to v1.3.0-beta.2
  2. You tried applying metadata (v1.2.2) and it failed

right?

If yes, can you after step 1, do a metadata export and then move to step 2 and see if you encounter the same error?

@jflambert
Copy link
Contributor

jflambert commented Jun 22, 2020

We can take it here (#5163)

stevefan1999-personal pushed a commit to stevefan1999-personal/graphql-engine that referenced this pull request Sep 12, 2020
@scriptonist @stevefan1999-personal
cli: fix cron triggers not being exported on a metadata export (close h…
31ce55e 
…asura#5047) (hasura#5060)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tirumaraiselvan tirumaraiselvan tirumaraiselvan approved these changes

@arvi3411301 arvi3411301 arvi3411301 approved these changes

Assignees

No one assigned

Labels

c/cli Related to CLI no-changelog-required

Projects

None yet

Milestone

v1.3

Development

Successfully merging this pull request may close these issues.

5 participants

@scriptonist @hasura-bot @jflambert @tirumaraiselvan @arvi3411301