这是indexloc提供的服务，不要输入任何密码
Skip to content

fix bug which arised when renaming a column/table if it was used to create the remote relationship #5005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Jun 9, 2020
Merged

fix bug which arised when renaming a column/table if it was used to create the remote relationship #5005

merged 15 commits into from
Jun 9, 2020

Conversation

@codingkarthik
Copy link
Contributor

@codingkarthik codingkarthik commented Jun 7, 2020 •
edited
Loading

fix #4995

Description

There was a bug which occurred when renaming a column which was being used in a remote relationship. This PR fixes that.

Changelog

  • CHANGELOG.md is updated with user-facing content relevant to this PR. If no changelog is required, then add the no-changelog-required label.

Affected components

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System
  • Tests
  • Other (list it)

Related Issues

Solution and Design

Steps to test and verify

Limitations, known bugs & workarounds

Server checklist

Catalog upgrade

Does this PR change Hasura Catalog version?

  • No
  • Yes
    • Updated docs with SQL for downgrading the catalog

Metadata

Does this PR add a new Metadata feature?

  • No
  • Yes
    • Does run_sql auto manages the new metadata through schema diffing?
      • Yes
      • Not required
    • Does run_sql auto manages the definitions of metadata on renaming?
      • Yes
      • Not required
    • Does export_metadata/replace_metadata supports the new metadata added?
      • Yes
      • Not required

GraphQL

  • No new GraphQL schema is generated
  • New GraphQL schema is being generated:
    • New types and typenames are correlated

Breaking changes

  • No Breaking changes

  • There are breaking changes:

    1. Metadata API

      Existing query types:

      • Modify args payload which is not backward compatible
      • Behavioural change of the API
      • Change in response JSON schema
      • Change in error code

    2. GraphQL API

      Schema Generation:

      • Change in any NamedType
      • Change in table field names

      Schema Resolve:-

      • Change in treatment of null value for any input fields

    3. Logging

      • Log JSON schema has changed
      • Log type names have changed

@codingkarthik codingkarthik changed the title Renaming col bug 4995 fix bug which arised when renaming a column if it was used to create the remote relationship Jun 7, 2020
@netlify
Copy link

netlify bot commented Jun 7, 2020 •
edited
Loading

Deploy preview for hasura-docs ready!

Built with commit f56371b

https://deploy-preview-5005--hasura-docs.netlify.app

@hasura-bot
Copy link
Contributor

hasura-bot commented Jun 7, 2020

Review app for commit 4f12099 deployed to Heroku: https://hge-ci-pull-5005.herokuapp.com
Docker image for server: hasura/graphql-engine:pull5005-4f120996

@codingkarthik codingkarthik marked this pull request as ready for review June 8, 2020 06:17
@codingkarthik codingkarthik requested a review from a team as a code owner June 8, 2020 06:17
@codingkarthik codingkarthik requested a review from rakeshkky June 8, 2020 06:17
tirumaraiselvan
tirumaraiselvan reviewed Jun 8, 2020
View reviewed changes
CHANGELOG.md Outdated
- server: fix importing of allow list query from metadata (fix #4687)
- server: flush log buffer during shutdown (#4800)
- server: fix edge case with printing logs on startup failure (fix #4772)
- server: fix bug which arised when renaming a column if it was used to create the remote relationship (fix #4995)
Copy link
Contributor

@tirumaraiselvan tirumaraiselvan Jun 8, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think we can ignore the changelog as it is a bug fix on master (i.e. unreleased version)

@hasura-bot
Copy link
Contributor

hasura-bot commented Jun 8, 2020

Review app for commit 08f70b1 deployed to Heroku: https://hge-ci-pull-5005.herokuapp.com
Docker image for server: hasura/graphql-engine:pull5005-08f70b18

@hasura-bot
Copy link
Contributor

hasura-bot commented Jun 8, 2020

Review app for commit c060aa0 deployed to Heroku: https://hge-ci-pull-5005.herokuapp.com
Docker image for server: hasura/graphql-engine:pull5005-c060aa08

rakeshkky
rakeshkky requested changes Jun 8, 2020
View reviewed changes
@hasura-bot
Copy link
Contributor

hasura-bot commented Jun 8, 2020

Review app for commit cfa51ec deployed to Heroku: https://hge-ci-pull-5005.herokuapp.com
Docker image for server: hasura/graphql-engine:pull5005-cfa51ecb

@hasura-bot
Copy link
Contributor

hasura-bot commented Jun 8, 2020

Review app for commit 07baad4 deployed to Heroku: https://hge-ci-pull-5005.herokuapp.com
Docker image for server: hasura/graphql-engine:pull5005-07baad4b

tirumaraiselvan
tirumaraiselvan approved these changes Jun 8, 2020
View reviewed changes
Copy link
Contributor

@tirumaraiselvan tirumaraiselvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CL not required.

@codingkarthik codingkarthik requested a review from a team as a code owner June 8, 2020 11:13
@hasura-bot
Copy link
Contributor

hasura-bot commented Jun 8, 2020

Review app for commit f56371b deployed to Heroku: https://hge-ci-pull-5005.herokuapp.com
Docker image for server: hasura/graphql-engine:pull5005-f56371b6

@codingkarthik codingkarthik requested a review from rakeshkky June 8, 2020 16:31
@codingkarthik codingkarthik changed the title fix bug which arised when renaming a column if it was used to create the remote relationship fix bug which arised when renaming a column/table if it was used to create the remote relationship Jun 9, 2020
rakeshkky
rakeshkky approved these changes Jun 9, 2020
View reviewed changes
Copy link
Member

@rakeshkky rakeshkky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Server LGTM

@hasura-bot
Copy link
Contributor

hasura-bot commented Jun 9, 2020

Review app for commit feca5f5 deployed to Heroku: https://hge-ci-pull-5005.herokuapp.com
Docker image for server: hasura/graphql-engine:pull5005-feca5f53

@hasura-bot
Copy link
Contributor

hasura-bot commented Jun 9, 2020

Review app for commit ea790d3 deployed to Heroku: https://hge-ci-pull-5005.herokuapp.com
Docker image for server: hasura/graphql-engine:pull5005-ea790d3b

@codingkarthik codingkarthik merged commit b782986 into hasura:master Jun 9, 2020
@hasura-bot
Copy link
Contributor

hasura-bot commented Jun 9, 2020

Review app https://hge-ci-pull-5005.herokuapp.com is deleted

stevefan1999-personal pushed a commit to stevefan1999-personal/graphql-engine that referenced this pull request Sep 12, 2020
@codingkarthik @stevefan1999-personal
fix bug which arised when renaming a column/table if it was used to c…
9917367 
…reate the remote relationship (hasura#5005)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tirumaraiselvan tirumaraiselvan tirumaraiselvan approved these changes

@rakeshkky rakeshkky rakeshkky approved these changes

+1 more reviewer

@beerose beerose beerose approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

no-changelog-required

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

renaming columns does not cascade if remote relationship is present

5 participants

@codingkarthik @hasura-bot @tirumaraiselvan @beerose @rakeshkky