这是indexloc提供的服务，不要输入任何密码
Skip to content

console: add option to flag an insertion as a migration (close #1766) #4993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 114 commits into from
Sep 29, 2020
Merged

console: add option to flag an insertion as a migration (close #1766) #4993

merged 114 commits into from
Sep 29, 2020

Conversation

@kolharsam
Copy link
Contributor

@kolharsam kolharsam commented Jun 5, 2020 •
edited
Loading

closes #1766

Description

This PR includes a checkbox that a user could check to indicate that the current insertion is also a migration

Changelog

  • CHANGELOG.md is updated with user-facing content relevant to this PR. If no changelog is required, then add the no-changelog-required label.

Affected components

  • Console

Solution and Design

A checkbox has been added to the "Insert Row" section of the Schema page.

Steps to test and verify

Start the console in cli mode and try inserting data into tables.

Limitations, known bugs & workarounds

Fixed this issue.

I found this issue when trying to check the This is a Migration box when the contents have been cleared, but reappear as soon as the checkbox is toggled
ezgif com-video-to-gif

Breaking changes

  • No Breaking changes

@hasura-bot
Copy link
Contributor

hasura-bot commented Jun 5, 2020

Review app for commit 5bee8e3 deployed to Heroku: https://hge-ci-pull-4993.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4993-5bee8e32

@hasura-bot
Copy link
Contributor

hasura-bot commented Jun 5, 2020

Review app for commit b4b3dc1 deployed to Heroku: https://hge-ci-pull-4993.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4993-b4b3dc11

@kolharsam kolharsam added the c/console Related to console label Jun 5, 2020
@kolharsam kolharsam changed the title console : add flag for migration on insert row on schema page console : add flag for migration on insertion Jun 5, 2020
@kolharsam kolharsam changed the title console : add flag for migration on insertion console : add flag for migration for insertion Jun 5, 2020
@netlify
Copy link

netlify bot commented Jun 6, 2020 •
edited
Loading

Deploy preview for hasura-docs ready!

Built with commit 477f6ee

https://deploy-preview-4993--hasura-docs.netlify.app

@hasura-bot
Copy link
Contributor

hasura-bot commented Jun 6, 2020

Review app for commit 99307e3 deployed to Heroku: https://hge-ci-pull-4993.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4993-99307e3f

kolharsam
kolharsam commented Jun 6, 2020
View reviewed changes
Copy link
Contributor Author

@kolharsam kolharsam left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

self-review notes

@kolharsam kolharsam marked this pull request as ready for review June 6, 2020 16:46
@kolharsam kolharsam requested review from a team as code owners June 6, 2020 16:46
@hasura-bot
Copy link
Contributor

hasura-bot commented Jun 8, 2020

Review app for commit 043992d deployed to Heroku: https://hge-ci-pull-4993.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4993-043992d0

@kolharsam kolharsam assigned kolharsam and unassigned beerose Jun 8, 2020
@kolharsam kolharsam assigned beerose and unassigned kolharsam Jun 9, 2020
@beerose beerose removed their assignment Aug 24, 2020
@hasura-bot
Copy link
Contributor

hasura-bot commented Aug 25, 2020

Review app for commit f6cc182 deployed to Heroku: https://hge-ci-pull-4993.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4993-f6cc1825

beerose
beerose approved these changes Aug 25, 2020
View reviewed changes
Copy link
Contributor

@beerose beerose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Console

@hasura-bot
Copy link
Contributor

hasura-bot commented Aug 25, 2020

Review app for commit 8aa0e23 deployed to Heroku: https://hge-ci-pull-4993.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4993-8aa0e23d

@hasura-bot
Copy link
Contributor

hasura-bot commented Aug 27, 2020

Review app for commit b9ebdf2 deployed to Heroku: https://hge-ci-pull-4993.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4993-b9ebdf2a

@beerose beerose changed the title console: add option to flag an insertion as a migration (closes #1766) console: add option to flag an insertion as a migration (close #1766) Sep 29, 2020
@kodiakhq kodiakhq bot merged commit 18e4c10 into hasura:master Sep 29, 2020
@kolharsam kolharsam mentioned this pull request Oct 1, 2020
Closed
2 tasks
@tirumaraiselvan tirumaraiselvan mentioned this pull request Oct 12, 2020
Closed
@beerose beerose mentioned this pull request Nov 16, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tirumaraiselvan tirumaraiselvan tirumaraiselvan approved these changes

@rikinsk rikinsk rikinsk approved these changes

+1 more reviewer

@beerose beerose beerose approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@beerose beerose

Labels

c/console Related to console

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Feature request: Ability to flag insert as a migration

6 participants

@kolharsam @hasura-bot @tirumaraiselvan @beerose @rikinsk @Varun-Choudhary