这是indexloc提供的服务，不要输入任何密码
Skip to content

console: add the ability to delete a role in permissions summary page (close #3353) #4987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 33 commits into from
Jun 19, 2020
Merged

console: add the ability to delete a role in permissions summary page (close #3353) #4987

merged 33 commits into from
Jun 19, 2020

Conversation

@kolharsam
Copy link
Contributor

@kolharsam kolharsam commented Jun 4, 2020 •
edited
Loading

resolve #3353

Description

  • The Schema Permissions Summary button/link is repositioned to be next to the Create Schema section
  • Also, delete a role using the delete button on the schema summary page

Changelog

  • CHANGELOG.md is updated with user-facing content relevant to this PR.

Affected components

  • Console

@hasura-bot
Copy link
Contributor

hasura-bot commented Jun 4, 2020

Review app for commit d1cd712 deployed to Heroku: https://hge-ci-pull-4987.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4987-d1cd712e

@hasura-bot
Copy link
Contributor

hasura-bot commented Jun 4, 2020

Review app for commit 7fadb83 deployed to Heroku: https://hge-ci-pull-4987.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4987-7fadb831

Sameer Kolhar added 3 commits June 5, 2020 17:16
add deleteRolePermissions to Actions
55a7f1c 
this commit adds a new action to help delete
permissons for a particular role across all tables and schemas
fix lint and format issues
d1d6952
update CHANGELOG
3b674bb
kolharsam
kolharsam commented Jun 5, 2020
View reviewed changes
kolharsam
kolharsam commented Jun 5, 2020
View reviewed changes
Copy link
Contributor Author

@kolharsam kolharsam left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Performed a self-review.

@kolharsam kolharsam marked this pull request as ready for review June 5, 2020 12:01
@kolharsam kolharsam requested review from a team as code owners June 5, 2020 12:01
@kolharsam kolharsam changed the title [wip] console: add ability to delete role permissions console: add ability to delete role permissions Jun 5, 2020
@kolharsam kolharsam added the c/console Related to console label Jun 5, 2020
@kolharsam kolharsam assigned kolharsam and beerose and unassigned kolharsam Jun 5, 2020
@hasura-bot
Copy link
Contributor

hasura-bot commented Jun 5, 2020

Review app for commit 3b674bb deployed to Heroku: https://hge-ci-pull-4987.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4987-3b674bbc

@kolharsam kolharsam changed the title console: add ability to delete role permissions console: add ability to delete role Jun 5, 2020
@kolharsam kolharsam changed the title console: add ability to delete role console: add ability to delete role globally Jun 5, 2020
@hasura-bot
Copy link
Contributor

hasura-bot commented Jun 5, 2020

Review app for commit 7e8109c deployed to Heroku: https://hge-ci-pull-4987.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4987-7e8109ce

beerose
beerose reviewed Jun 9, 2020
View reviewed changes
Copy link
Contributor

@beerose beerose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rikinsk A couple of points to discuss.

Schema permissions summary behaves as a link (redirects to a different page), but looks like a button. Should we make it look as a link or say something like Show permissions summary (so that it indicates it's an action.)?

Screenshot 2020-06-09 at 20 41 41

These buttons feel inconsistent with the rest of the console. I remember we were talking about having buttons with text instead of icons. What about having Copy and Delete buttons here? On the other hand it will take more space.

Screenshot 2020-06-09 at 20 45 09

@beerose beerose requested a review from rikinsk June 9, 2020 19:00
@hasura-bot
Copy link
Contributor

hasura-bot commented Jun 10, 2020

Review app for commit 8417f85 deployed to Heroku: https://hge-ci-pull-4987.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4987-8417f85e

@hasura-bot
Copy link
Contributor

hasura-bot commented Jun 17, 2020

Review app for commit d8585fa deployed to Heroku: https://hge-ci-pull-4987.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4987-d8585faf

rikinsk
rikinsk requested changes Jun 18, 2020
View reviewed changes
Copy link
Member

@rikinsk rikinsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor change, Can you make the title for the delete role button as Delete role permissions. It says Copy permissions currently

@kolharsam
Copy link
Contributor Author

kolharsam commented Jun 18, 2020 •
edited
Loading

Minor change, Can you make the title for the delete role button as Delete role permissions. It says Copy permissions currently

Sorry I missed that!

@kolharsam kolharsam requested a review from rikinsk June 18, 2020 12:10
rikinsk
rikinsk requested changes Jun 18, 2020
View reviewed changes
Copy link
Member

@rikinsk rikinsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kolharsam Another very minor nitpick. The clickable are for the Show permissions summary button is a little off. I am able to click on the space to the left of the button as well. I guess moving the margin from the button to its parent link should fix it.

@hasura-bot
Copy link
Contributor

hasura-bot commented Jun 18, 2020

Review app for commit a789551 deployed to Heroku: https://hge-ci-pull-4987.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4987-a7895516

@hasura-bot
Copy link
Contributor

hasura-bot commented Jun 18, 2020

Review app for commit 4495a03 deployed to Heroku: https://hge-ci-pull-4987.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4987-4495a03f

rikinsk
rikinsk approved these changes Jun 18, 2020
View reviewed changes
Copy link
Member

@rikinsk rikinsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UX approved

tirumaraiselvan
tirumaraiselvan reviewed Jun 19, 2020
View reviewed changes
@hasura-bot
Copy link
Contributor

hasura-bot commented Jun 19, 2020

Review app for commit cc3f747 deployed to Heroku: https://hge-ci-pull-4987.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4987-cc3f7470

beerose
beerose reviewed Jun 19, 2020
View reviewed changes
@beerose beerose requested a review from tirumaraiselvan June 19, 2020 08:10
tirumaraiselvan
tirumaraiselvan approved these changes Jun 19, 2020
View reviewed changes
Copy link
Contributor

@tirumaraiselvan tirumaraiselvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changelog approved

@beerose beerose changed the title console: add ability to delete role globally console: add the ability to delete a role in permissions summary page (close #3353) Jun 19, 2020
@hasura-bot
Copy link
Contributor

hasura-bot commented Jun 19, 2020

Review app for commit eebff9b deployed to Heroku: https://hge-ci-pull-4987.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4987-eebff9b0

@hasura-bot
Copy link
Contributor

hasura-bot commented Jun 19, 2020

Review app for commit 87520e5 deployed to Heroku: https://hge-ci-pull-4987.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4987-87520e5d

@rikinsk rikinsk merged commit 4293714 into hasura:master Jun 19, 2020
@hasura-bot
Copy link
Contributor

hasura-bot commented Jun 19, 2020

Review app https://hge-ci-pull-4987.herokuapp.com is deleted

stevefan1999-personal pushed a commit to stevefan1999-personal/graphql-engine that referenced this pull request Sep 12, 2020
@stevefan1999-personal
console: add the ability to delete a role in permissions summary page (…
39cd53c 
…close hasura#3353) (hasura#4987)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tirumaraiselvan tirumaraiselvan tirumaraiselvan approved these changes

@rikinsk rikinsk rikinsk approved these changes

+1 more reviewer

@beerose beerose beerose approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@beerose beerose

Labels

c/console Related to console

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

allow renaming or deleting roles globally in console

5 participants

@kolharsam @hasura-bot @rikinsk @tirumaraiselvan @beerose