这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@rakeshkky
Copy link
Member

Description

What component does this PR affect?

  • Server
  • Console
  • CLI
  • Docs
  • Community Content

Requires changes from other components? If yes, please mark the components:

  • Server
  • Console
  • CLI
  • Docs
  • Community Content

Related Issue

#494

Solution and Design

Use quote_ident() SQL function over constraint_name in insert trigger function definition.

Tests

Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have read the contributing guide and my code conforms to the guidelines.
  • This change requires a change in the documentation.
  • I have updated the documentation accordingly.

@rakeshkky rakeshkky added s/ok-to-merge Status: This pull request can be merged to master c/server Related to server labels Sep 20, 2018
@rakeshkky rakeshkky self-assigned this Sep 20, 2018
@rakeshkky rakeshkky requested a review from 0x777 September 20, 2018 09:37
Copy link
Member

@0x777 0x777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add a test case

@hasura-bot
Copy link
Contributor

Review app available at: https://hge-ci-pull-497.herokuapp.com

@hasura-bot
Copy link
Contributor

Review app available at: https://hge-ci-pull-497.herokuapp.com

@shahidhk shahidhk merged commit 8f6b19d into hasura:master Sep 20, 2018
@hasura-bot
Copy link
Contributor

Review app https://hge-ci-pull-497.herokuapp.com is deleted

@cloudflare-workers-and-pages
Copy link

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: e48f3cb
Status:🚫  Build failed.

View logs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c/server Related to server s/ok-to-merge Status: This pull request can be merged to master

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants