这是indexloc提供的服务，不要输入任何密码
Skip to content

console: display line number that error originated from in GraphQL editor (close #4849) #4942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 27 commits into from
Jul 9, 2020
Merged

console: display line number that error originated from in GraphQL editor (close #4849) #4942

merged 27 commits into from
Jul 9, 2020

Conversation

@tanvibhakta
Copy link
Contributor

@tanvibhakta tanvibhakta commented May 30, 2020 •
edited by beerose
Loading

display line number for the first error encountered in the custom types editor

Changelog

  • CHANGELOG.md is updated with user-facing content relevant to this PR. If no changelog is required, then add the no-changelog-required label.

Affected components

  • Console

Solution and Design

The error object available here is an object of type GraphQLError. It contains the location of the origin of the error within itself.

Steps to test and verify

console > Actions tab > Custom Types button on the left hand side -> define a custom type in the editor. Where previously an error used to show up, it now shows up with the line number the error is caught on as well.

Limitations, known bugs & workarounds

The editor displays the first error message encountered, and therefore the line number displayed will be for that error.

Related issues

#4849

@hasura-bot
Copy link
Contributor

hasura-bot commented May 30, 2020

Beep boop! 🤖

Hey @tanvibhakta, thanks for your PR!

One of my human friends will review this PR and get back to you as soon as possible.

Stay awesome! 😎

@hasura-bot
Copy link
Contributor

hasura-bot commented May 30, 2020

Review app for commit be7e1d2 deployed to Heroku: https://hge-ci-pull-4942.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4942-be7e1d24

@tanvibhakta tanvibhakta marked this pull request as ready for review May 30, 2020 09:11
@tanvibhakta tanvibhakta requested review from a team as code owners May 30, 2020 09:11
@hasura-bot
Copy link
Contributor

hasura-bot commented May 30, 2020

Review app for commit 5068a88 deployed to Heroku: https://hge-ci-pull-4942.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4942-5068a887

@beerose beerose self-assigned this May 30, 2020
beerose
beerose suggested changes May 30, 2020
View reviewed changes
Copy link
Contributor

@beerose beerose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR! This looks great 😉

Left one small comment.

@tanvibhakta
display line number of error message origin (fix hasura#4849)
7ee907c 
displays line number for the first error encountered in the custom types editor
@hasura-bot
Copy link
Contributor

hasura-bot commented May 30, 2020

Review app for commit 7ee907c deployed to Heroku: https://hge-ci-pull-4942.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4942-7ee907c7

tirumaraiselvan
tirumaraiselvan approved these changes Jun 1, 2020
View reviewed changes
Copy link
Contributor

@tirumaraiselvan tirumaraiselvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changelog approved

@hasura-bot
Copy link
Contributor

hasura-bot commented Jun 3, 2020

Review app for commit b583bd8 deployed to Heroku: https://hge-ci-pull-4942.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4942-b583bd8f

@beerose
Copy link
Contributor

beerose commented Jun 5, 2020

Hi @tanvibhakta, would you mind doing the same thing for Action Definition editor?

@hasura-bot
Copy link
Contributor

hasura-bot commented Jul 2, 2020

Review app for commit 337360e deployed to Heroku: https://hge-ci-pull-4942.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4942-337360e8

beerose
beerose reviewed Jul 3, 2020
View reviewed changes
@hasura-bot
Copy link
Contributor

hasura-bot commented Jul 3, 2020

Review app for commit 812beeb deployed to Heroku: https://hge-ci-pull-4942.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4942-812beeb3

@hasura-bot
Copy link
Contributor

hasura-bot commented Jul 3, 2020

Review app for commit 0f8b107 deployed to Heroku: https://hge-ci-pull-4942.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4942-0f8b107e

@hasura-bot
Copy link
Contributor

hasura-bot commented Jul 6, 2020

Review app for commit fe1b0a7 deployed to Heroku: https://hge-ci-pull-4942.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4942-fe1b0a7e

@hasura-bot
Copy link
Contributor

hasura-bot commented Jul 6, 2020

Review app for commit 7a38bb2 deployed to Heroku: https://hge-ci-pull-4942.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4942-7a38bb20

beerose
beerose reviewed Jul 8, 2020
View reviewed changes
Aleksandra Sikora and others added 2 commits July 8, 2020 18:22
@beerose beerose changed the title display line number of error message origin (fix #4849) console: display line number that error originated from in GraphQL editor (close #4849) Jul 8, 2020
@hasura-bot
Copy link
Contributor

hasura-bot commented Jul 8, 2020

Review app for commit a02ff80 deployed to Heroku: https://hge-ci-pull-4942.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4942-a02ff80f

@hasura-bot
Copy link
Contributor

hasura-bot commented Jul 9, 2020

Review app for commit ac04237 deployed to Heroku: https://hge-ci-pull-4942.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4942-ac042373

@netlify
Copy link

netlify bot commented Jul 9, 2020 •
edited
Loading

Deploy preview for hasura-docs ready!

Built with commit 7735586

https://deploy-preview-4942--hasura-docs.netlify.app

@hasura-bot
Copy link
Contributor

hasura-bot commented Jul 9, 2020

Review app for commit d44b03b deployed to Heroku: https://hge-ci-pull-4942.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4942-d44b03b4

@beerose beerose merged commit 51174ce into hasura:master Jul 9, 2020
@hasura-bot
Copy link
Contributor

hasura-bot commented Jul 9, 2020

Review app https://hge-ci-pull-4942.herokuapp.com is deleted

@hasura-bot
Copy link
Contributor

hasura-bot commented Jul 9, 2020

Beep boop! 🤖

GIF

Awesome work @tanvibhakta! All of us at Hasura ❤️ what you did.

Thanks again 🤗

stevefan1999-personal pushed a commit to stevefan1999-personal/graphql-engine that referenced this pull request Sep 12, 2020
@tanvibhakta @stevefan1999-personal
console: display line number that error originated from in GraphQL ed…
ba64df8 
…itor (close hasura#4849) (hasura#4942)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tirumaraiselvan tirumaraiselvan tirumaraiselvan approved these changes

+1 more reviewer

@beerose beerose beerose approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@beerose beerose

Labels

c/console Related to console community-contrib 🙏🏽

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@tanvibhakta @hasura-bot @beerose @tirumaraiselvan @rikinsk