This is a very well written code! Nice!

A couple of points regarding functionality:

1. After clicking Save for setting session argument app redirects to data/schema/public. Is it a bug or a feature?

2. Can we prefill input after setting the session variable? Right now it remains empty after visiting the modify page again.

3. The name of the migration should indicate setting session variable.

4. This is generated down migration — check missing name:

- args:
    name: ""
    schema: public
  type: untrack_function
- args:
    name: get_session_role
    schema: public
  type: track_function

Is this down migration needed?

5. Let's be consistent with the naming. Sometimes there's Session variable argument, sometimes Session argument variable. The same goes for the casing.
   Example:

In the docs, we refer to this by session variables, and I think we should stick to just session variable, lowercase.

6. There's no error notification on server error. Can you check this?

7. What about having Learn more link to the docs for it? cc @rikinsk

I have a few points from a UX perspective:

• Can we make this page look consistent with Modify Page for views. i.e. Add a heading called Function definition and move the Modify button next to it.
• Use the term Session argument everywhere (argument doesnt need to start with capital).
• Update tooltip text to: the function argument into which hasura session variables will be passed
• Add a Know more link next to the tooltip linking to https://hasura.io/docs/1.0/graphql/manual/schema/custom-functions.html#accessing-hasura-session-variables-in-custom-functions (there is a KnowMoreLink component for this)
• in the placeholder change hasura-session to hasura_session. - are not allowed in SQL
• After saving the session argument, just close the session argument editor. No redirect to schema page.
• Once a session argument is added, prefill its value in the input box when edit is clicked
• Disable the save button when the input value is unchanged from the current value
• Currently, there is no way to remove a session argument once set. Allow users to save an empty string as well which we can interpret as no session argument is set

UX approved

Down migration for setting session arg is incorrect:

- args:
    name: customfunctionwithsessionarg
    schema: public
  type: untrack_function
- args:
    configuration: {}
    function:
      name: customfunctionwithsessionarg
      schema: public
  type: track_function

Missing version: 2.