这是indexloc提供的服务，不要输入任何密码
Skip to content

1.2.1 fix and fix explain queries with role permissions (fix #4816) #4838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 22, 2020
Merged

1.2.1 fix and fix explain queries with role permissions (fix #4816) #4838

merged 2 commits into from
May 22, 2020

Conversation

@rakeshkky
Copy link
Member

@rakeshkky rakeshkky commented May 21, 2020 •
edited
Loading

Note to Reviewers:-
No need to review 1.2.1 fix which is already reviewed and released. Only review the fix related to #4816 bug which is in this commit.

Description

Include v1.2.1 release fix in master. Also fixes minor bug related to GraphQL explain queries with role permissions which is originally caused via v1.2.1 fix.

Changelog

  • CHANGELOG.md is updated with user-facing content relevant to this PR.

Affected components

  • Server
  • Console
  • CLI
  • Docs
  • Tests

Related Issues

Fix #4816

Solution and Design

Steps to test and verify

Limitations, known bugs & workarounds

Server checklist

Catalog upgrade

Does this PR change Hasura Catalog version?

  • No
  • Yes

Metadata

Does this PR add a new Metadata feature?

  • No
  • Yes

GraphQL

  • No new GraphQL schema is generated
  • New GraphQL schema is being generated

Breaking changes

  • No Breaking changes
  • There are breaking changes

@rakeshkky rakeshkky added the c/server Related to server label May 21, 2020
@rakeshkky rakeshkky self-assigned this May 21, 2020
@rakeshkky rakeshkky requested a review from 0x777 May 21, 2020 16:07
@rakeshkky rakeshkky marked this pull request as ready for review May 21, 2020 16:10
@rakeshkky rakeshkky requested review from a team as code owners May 21, 2020 16:10
@hasura-bot
Copy link
Contributor

hasura-bot commented May 21, 2020

Review app for commit b29bbc8 deployed to Heroku: https://hge-ci-pull-4838.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4838-b29bbc87

tirumaraiselvan
tirumaraiselvan approved these changes May 21, 2020
View reviewed changes
Copy link
Contributor

@tirumaraiselvan tirumaraiselvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changelog

@netlify
Copy link

netlify bot commented May 22, 2020 •
edited
Loading

Deploy preview for hasura-docs ready!

Built with commit ee0602e

https://deploy-preview-4838--hasura-docs.netlify.app

@hasura-bot
Copy link
Contributor

hasura-bot commented May 22, 2020

Review app for commit f755718 deployed to Heroku: https://hge-ci-pull-4838.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4838-f755718b

0x777
0x777 requested changes May 22, 2020
View reviewed changes
Copy link
Member

@0x777 0x777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you squash the last 4 commits (related to explain) into a single commit? We can then directly merge this into master without squashing.

@hasura-bot
Copy link
Contributor

hasura-bot commented May 22, 2020

Review app for commit 8c1a157 deployed to Heroku: https://hge-ci-pull-4838.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4838-8c1a157e

@hasura-bot
Copy link
Contributor

hasura-bot commented May 22, 2020

Review app for commit ee0602e deployed to Heroku: https://hge-ci-pull-4838.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4838-ee0602e7

@0x777 0x777 merged commit e347ef3 into hasura:master May 22, 2020
@hasura-bot
Copy link
Contributor

hasura-bot commented May 22, 2020

Review app https://hge-ci-pull-4838.herokuapp.com is deleted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@0x777 0x777 0x777 requested changes

@tirumaraiselvan tirumaraiselvan tirumaraiselvan approved these changes

Assignees

@rakeshkky rakeshkky

Labels

c/server Related to server

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Analyze button does not show permission filters anymore

4 participants

@rakeshkky @hasura-bot @0x777 @tirumaraiselvan