这是indexloc提供的服务，不要输入任何密码
Skip to content

console: migrate main state to typescript #4804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jun 15, 2020
Merged

console: migrate main state to typescript #4804

merged 8 commits into from
Jun 15, 2020

Conversation

@marekdano
Copy link
Contributor

@marekdano marekdano commented May 18, 2020

Description

This PR migrates Main State to Typescript.

Changelog

  • CHANGELOG.md is updated with user-facing content relevant to this PR.

Affected components

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System
  • Tests
  • Other (list it)

Related Issues

#4314

Server checklist

Catalog upgrade

Does this PR change Hasura Catalog version?

  • No
  • Yes
    • Updated docs with SQL for downgrading the catalog

Metadata

Does this PR add a new Metadata feature?

  • No
  • Yes
    • Does run_sql auto manages the new metadata through schema diffing?
      • Yes
      • Not required
    • Does run_sql auto manages the definitions of metadata on renaming?
      • Yes
      • Not required
    • Does export_metadata/replace_metadata supports the new metadata added?
      • Yes
      • Not required

GraphQL

  • No new GraphQL schema is generated
  • New GraphQL schema is being generated:
    • New types and typenames are correlated

Breaking changes

  • No Breaking changes
  • There are breaking changes:

@marekdano marekdano requested a review from a team as a code owner May 18, 2020 16:37
@hasura-bot
Copy link
Contributor

hasura-bot commented May 18, 2020

Beep boop! 🤖

Hey @marekdano, thanks for your PR!

One of my human friends will review this PR and get back to you as soon as possible.

Stay awesome! 😎

@netlify
Copy link

netlify bot commented May 18, 2020 •
edited
Loading

Deploy preview for hasura-docs ready!

Built with commit 0ae6b17

https://deploy-preview-4804--hasura-docs.netlify.app

@marekdano
Copy link
Contributor Author

marekdano commented May 18, 2020

I added a few of unknown types to the MainState. Can you advise me what types should I enter when I want to replace them?

@beerose beerose self-assigned this May 18, 2020
@hasura-bot
Copy link
Contributor

hasura-bot commented May 18, 2020

Review app for commit 852cd1c deployed to Heroku: https://hge-ci-pull-4804.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4804-852cd1c3

@beerose beerose mentioned this pull request May 29, 2020
Closed
46 tasks
beerose
beerose approved these changes Jun 6, 2020
View reviewed changes
Copy link
Contributor

@beerose beerose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR!

@beerose beerose requested a review from rikinsk June 6, 2020 09:08
@beerose beerose removed their assignment Jun 6, 2020
@hasura-bot
Copy link
Contributor

hasura-bot commented Jun 6, 2020

Review app for commit 2fadebc deployed to Heroku: https://hge-ci-pull-4804.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4804-2fadebc8

@hasura-bot
Copy link
Contributor

hasura-bot commented Jun 6, 2020

Review app for commit b5ee8b3 deployed to Heroku: https://hge-ci-pull-4804.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4804-b5ee8b32

@hasura-bot
Copy link
Contributor

hasura-bot commented Jun 8, 2020

Review app for commit 479865f deployed to Heroku: https://hge-ci-pull-4804.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4804-479865f0

@hasura-bot
Copy link
Contributor

hasura-bot commented Jun 9, 2020

Review app for commit 8821a52 deployed to Heroku: https://hge-ci-pull-4804.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4804-8821a529

@hasura-bot
Copy link
Contributor

hasura-bot commented Jun 9, 2020

Review app for commit 0ae6b17 deployed to Heroku: https://hge-ci-pull-4804.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4804-0ae6b179

@hasura-bot
Copy link
Contributor

hasura-bot commented Jun 9, 2020

Review app for commit 0e0edc4 deployed to Heroku: https://hge-ci-pull-4804.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4804-0e0edc49

@rikinsk rikinsk removed their assignment Jun 15, 2020
@hasura-bot
Copy link
Contributor

hasura-bot commented Jun 15, 2020

Review app for commit f83cb04 deployed to Heroku: https://hge-ci-pull-4804.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4804-f83cb049

@beerose beerose changed the title Add interface of MainState into Main State. console: migrate main state to typescript Jun 15, 2020
@beerose beerose merged commit 65920fb into hasura:master Jun 15, 2020
@hasura-bot
Copy link
Contributor

hasura-bot commented Jun 15, 2020

Beep boop! 🤖

GIF

Awesome work @marekdano! All of us at Hasura ❤️ what you did.

Thanks again 🤗

@hasura-bot
Copy link
Contributor

hasura-bot commented Jun 15, 2020

Review app https://hge-ci-pull-4804.herokuapp.com is deleted

stevefan1999-personal pushed a commit to stevefan1999-personal/graphql-engine that referenced this pull request Sep 12, 2020
@marekdano @stevefan1999-personal
console: migrate main state to typescript (hasura#4804)
17a16fd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rikinsk rikinsk rikinsk approved these changes

+1 more reviewer

@beerose beerose beerose approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@beerose beerose

Labels

c/console Related to console community-contrib 🙏🏽 no-changelog-required typescript-migration 🙌

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@marekdano @hasura-bot @beerose @rikinsk