这是indexloc提供的服务，不要输入任何密码
Skip to content

Migrate QueryBuilderJson to TS. #4803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Migrate QueryBuilderJson to TS. #4803

wants to merge 6 commits into from

Conversation

@marekdano
Copy link
Contributor

@marekdano marekdano commented May 18, 2020

Description

This PR migrates QueryBuilderJson to Typescript.

Changelog

  • CHANGELOG.md is updated with user-facing content relevant to this PR.

Affected components

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System
  • Tests
  • Other (list it)

Related Issues

#4314

Catalog upgrade

Does this PR change Hasura Catalog version?

  • No
  • Yes
    • Updated docs with SQL for downgrading the catalog

Metadata

Does this PR add a new Metadata feature?

  • No
  • Yes
    • Does run_sql auto manages the new metadata through schema diffing?
      • Yes
      • Not required
    • Does run_sql auto manages the definitions of metadata on renaming?
      • Yes
      • Not required
    • Does export_metadata/replace_metadata supports the new metadata added?
      • Yes
      • Not required

GraphQL

  • No new GraphQL schema is generated
  • New GraphQL schema is being generated:
    • New types and typenames are correlated

Breaking changes

  • No Breaking changes
  • There are breaking changes:

@marekdano marekdano requested a review from a team as a code owner May 18, 2020 16:06
@hasura-bot
Copy link
Contributor

hasura-bot commented May 18, 2020

Beep boop! 🤖

Hey @marekdano, thanks for your PR!

One of my human friends will review this PR and get back to you as soon as possible.

Stay awesome! 😎

@netlify
Copy link

netlify bot commented May 18, 2020 •
edited
Loading

✔️ Deploy Preview for hasura-docs ready!

🔨 Explore the source changes: ce52d1f

🔍 Inspect the deploy log: https://app.netlify.com/sites/hasura-docs/deploys/60dc20aa4e073f0008742638

😎 Browse the preview: https://deploy-preview-4803--hasura-docs.netlify.app

@beerose beerose self-assigned this May 18, 2020
@hasura-bot
Copy link
Contributor

hasura-bot commented May 18, 2020

Review app for commit 9e9b200 deployed to Heroku: https://hge-ci-pull-4803.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4803-9e9b200b

@beerose beerose mentioned this pull request May 29, 2020
Closed
46 tasks
@soorajshankar
Copy link
Member

soorajshankar commented Jun 29, 2021

Hello @marekdano 👋🏼

Thank you for the PR 🎉

I am resolving the conflicts here, and will merge this soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@beerose beerose

Labels

c/console Related to console community-contrib 🙏🏽 no-changelog-required typescript-migration 🙌

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@marekdano @hasura-bot @soorajshankar @beerose