docs: improve actions documentation #4743
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for hasura-docs ready! Built with commit 3282545 |
|
Deploy preview for hasura-docs ready! Built with commit 0c64cf9 |
|
@marionschleifer Could you please add the results of this conversation to the docs? Possibly giving an example how exactly to do the things discussed there about the HMAC on a node/express action handler? If I understand correctly this commit currently only refers to a secret, stored as an env variable and passed to the handler, right? |
tirumaraiselvan
approved these changes
May 21, 2020
tirumaraiselvan
approved these changes
May 21, 2020
rikinsk
approved these changes
May 21, 2020
Contributor
|
Review app https://hge-ci-pull-4743.herokuapp.com is deleted |
rikinsk
pushed a commit
that referenced
this pull request
May 21, 2020
stevefan1999-personal
pushed a commit
to stevefan1999-personal/graphql-engine
that referenced
this pull request
Sep 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
- Add a new page that explains how to secure actions by adding an action secret as a header- Add a sentence mentioning how Hasura types can be "reused" in action relationships- Add an example section to actions including an example on array relationships from actionsSimplified the above into the current existing pages itself
Changelog
CHANGELOG.mdis updated with user-facing content relevant to this PR.Affected components
Related Issues
#4645
Affected pages:
https://deploy-preview-4743--hasura-docs.netlify.app/graphql/manual/actions/handlers/securing-handler.html
https://deploy-preview-4743--hasura-docs.netlify.app/graphql/manual/actions/reuse-types-actions.html
https://deploy-preview-4743--hasura-docs.netlify.app/graphql/manual/actions/action-examples.html