-
Notifications
You must be signed in to change notification settings - Fork 2.8k
console: restore partial support for foreign tables (fix #4714) #4742
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
CHANGELOG.md
Outdated
| - console: avoid count queries for large tables (#4692) | ||
| - console: add read replica support section to pro popup (#4118) | ||
| - console: allow modifying default value for PK (fix #4075) (#4679) | ||
| - console: re-enable partial support for foreign tables |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is it "partial"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because there never was explicit support for foreign tables in the console. They were misclassified as views, meaning several features of the console never worked with them. It was kind of an "accidental support", in a way. This PR restores this, but doesn't go any further.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah I see.
Co-authored-by: Tirumarai Selvan <tirumarai.selvan@gmail.com>
|
Review app for commit 00b59da deployed to Heroku: https://hge-ci-pull-4742.herokuapp.com |
tirumaraiselvan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changelog approved
|
Review app for commit ab1285c deployed to Heroku: https://hge-ci-pull-4742.herokuapp.com |
|
Review app https://hge-ci-pull-4742.herokuapp.com is deleted |
Description
This PR fixes an oversight of #4270.
While the console never had explicit support for foreign tables, they used to be implicitly queried alongside tables and views, as foreign tables do appear in
information_schema.tables. In #4270, we switched to a more direct approach, explicitly queryingpg_classinstead, and explicitly specifying which types of postgres items we wanted to return: tables, views, and materialized views, effectively dropping support for foreign tables.This PR fixes this by adding foreign tables to the list of items that the console fetches. However, while this restores a previously lost functionality, the console still doesn't have explicit support for foreign tables: they are misclassified as views, and some of the features of the console won't work with them (for instance, the "delete view" (sic) button will fail to drop the foreign table).
Adding full support for them in the console is beyond the scope of this PR and will be added to the backlog for triage.
Changelog
CHANGELOG.mdis updated with user-facing content relevant to this PR.Affected components
Steps to test and verify
This PR doesn't have tests. After discussing it internally, we agreed that the ROI of the effort it would take to add them wouldn't be worth it, especially considering foreign tables are only partially supported.
The simplest way to verify this is to do something along those lines, using a running postgres server as its own foreign server: