这是indexloc提供的服务，不要输入任何密码
Skip to content

server: use a new version of graphql-parser-hs to avoid loss of precision #4741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
May 13, 2020
Merged

server: use a new version of graphql-parser-hs to avoid loss of precision #4741

merged 5 commits into from
May 13, 2020

Conversation

@abooij
Copy link
Contributor

@abooij abooij commented May 12, 2020 •
edited
Loading

Description

Fixes #4733. See also hasura/graphql-parser-hs#29.

Changelog

  • CHANGELOG.md is updated with user-facing content relevant to this PR.

Affected components

  • Server

Solution and Design

The new version of graphql-parser-hs converts a Scientific parsed by Aeson to an Integer only when it contains neither a period . nor scientific notation e or E.

Steps to test and verify

A regression test has been added.

Server checklist

Catalog upgrade

Does this PR change Hasura Catalog version?

  • No

Metadata

Does this PR add a new Metadata feature?

  • No

GraphQL

  • No new GraphQL schema is generated

Breaking changes

  • No Breaking changes

@hasura-bot
Copy link
Contributor

hasura-bot commented May 12, 2020

Review app for commit 5aba3d7 deployed to Heroku: https://hge-ci-pull-4741.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4741-5aba3d73

@netlify
Copy link

netlify bot commented May 12, 2020

Deploy preview for hasura-docs ready!

Built with commit 9c77b2d

https://deploy-preview-4741--hasura-docs.netlify.app

@abooij abooij added the c/server Related to server label May 12, 2020
@abooij abooij changed the title Use a new version of graphql-parser-hs to avoid loss of precision server: use a new version of graphql-parser-hs to avoid loss of precision May 12, 2020
@abooij abooij marked this pull request as ready for review May 12, 2020 12:15
@abooij abooij requested a review from a team as a code owner May 12, 2020 12:15
@hasura-bot
Copy link
Contributor

hasura-bot commented May 12, 2020

Review app for commit 7a4d69f deployed to Heroku: https://hge-ci-pull-4741.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4741-7a4d69f8

@abooij abooij force-pushed the 4733-small-numbers-_inc branch from 7a4d69f to 4d5966c Compare May 12, 2020 13:05
@hasura-bot
Copy link
Contributor

hasura-bot commented May 12, 2020

Review app for commit 4d5966c deployed to Heroku: https://hge-ci-pull-4741.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4741-4d5966cf

tirumaraiselvan
tirumaraiselvan approved these changes May 13, 2020
View reviewed changes
Copy link
Contributor

@tirumaraiselvan tirumaraiselvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changelog approved

@hasura-bot
Copy link
Contributor

hasura-bot commented May 13, 2020

Review app for commit 85e58f4 deployed to Heroku: https://hge-ci-pull-4741.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4741-85e58f45

@abooij abooij merged commit 2735d28 into hasura:master May 13, 2020
@hasura-bot
Copy link
Contributor

hasura-bot commented May 13, 2020

Review app https://hge-ci-pull-4741.herokuapp.com is deleted

shahidhk pushed a commit that referenced this pull request May 29, 2020
@shahidhk
server: use a new version of graphql-parser-hs to avoid loss of preci…
fe9cffd 
…sion (#4741)

Fixes #4733.  See also hasura/graphql-parser-hs#29.
stevefan1999-personal pushed a commit to stevefan1999-personal/graphql-engine that referenced this pull request Sep 12, 2020
@stevefan1999-personal
server: use a new version of graphql-parser-hs to avoid loss of preci…
fdd51db 
…sion (hasura#4741)

Fixes hasura#4733.  See also hasura/graphql-parser-hs#29.
karthikvt26 pushed a commit to karthikvt26/graphql-engine that referenced this pull request Nov 17, 2020
@karthikvt26
server: use a new version of graphql-parser-hs to avoid loss of preci…
fecad8f 
…sion (hasura#4741)

Fixes hasura#4733.  See also hasura/graphql-parser-hs#29.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@0x777 0x777 0x777 approved these changes

@tirumaraiselvan tirumaraiselvan tirumaraiselvan approved these changes

Assignees

No one assigned

Labels

c/server Related to server

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[BUG] Hasura doesn't calculate correctly small numbers _inc

4 participants

@abooij @hasura-bot @0x777 @tirumaraiselvan