-
Notifications
You must be signed in to change notification settings - Fork 2.8k
console changes for Scheduled Triggers #4732
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
* console: fix ~ react table first child width for event logs * console: update ~ react table data positioned to center
|
Deploy preview for hasura-docs ready! Built with commit 99cc02b |
|
Review app for commit cf3d1ba deployed to Heroku: https://hge-ci-pull-4732.herokuapp.com |
e30e416 to
28174b7
Compare
|
Review app for commit 28174b7 deployed to Heroku: https://hge-ci-pull-4732.herokuapp.com |
|
Review app for commit 45f6e58 deployed to Heroku: https://hge-ci-pull-4732.herokuapp.com |
45f6e58 to
c7ec515
Compare
|
Review app for commit c7ec515 deployed to Heroku: https://hge-ci-pull-4732.herokuapp.com |
…e-scheduled-triggers
|
/heroku deploy |
2 similar comments
|
/heroku deploy |
|
/heroku deploy |
|
Review app for commit 82a22ec deployed to Heroku: https://hge-ci-pull-4732.herokuapp.com |
|
Review app for commit 277f87d deployed to Heroku: https://hge-ci-pull-4732.herokuapp.com |
|
Review app for commit 0122aa0 deployed to Heroku: https://hge-ci-pull-4732.herokuapp.com |
|
Review app for commit 0b953b3 deployed to Heroku: https://hge-ci-pull-4732.herokuapp.com |
|
Review app https://hge-ci-pull-4732.herokuapp.com is deleted |
Description
This PR does the following:
Scheduled TrigersEvent Triggersin TypeScriptEventsCertain TypeScript patterns that have been followed:
anyhas been used as a type for the following:dispatch: Can't think of a better way until we have a union type that encompasses all redux actions and we have a way to handle thunk. Suggestions are welcomeEvery component has its prop type next to it. All components will have the following structure.
Notes for the reviewer:
The UI for Event Triggers (JSX) has been taken as is from the existing codebase and not much changes are made; there's definitely a scope for improvement from UI POV, but that's for a separate PR.
src/components/Common/utilshave been converted to TS. A detailed review on these would be nice because these utils are more or less the core of the app.API has changed, so the full functionality feedback might be redundant for now.
Use this docker image (
hasura/graphql-engine:pull3553-0134b257)Changelog
CHANGELOG.mdis updated with user-facing content relevant to this PR.Affected components