这是indexloc提供的服务，不要输入任何密码
Skip to content

console: migrate telemetry to typescript #4737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Jun 9, 2020
Merged

console: migrate telemetry to typescript #4737

merged 11 commits into from
Jun 9, 2020

Conversation

@marekdano
Copy link
Contributor

@marekdano marekdano commented May 11, 2020 •
edited by beerose
Loading

Description

I migrated Telemetry to TS.

Changelog

  • CHANGELOG.md is updated with user-facing content relevant to this PR.

Affected components

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System
  • Tests
  • Other (list it)

Related Issues

Releates to #4314

@marekdano marekdano requested a review from a team as a code owner May 11, 2020 17:12
@hasura-bot
Copy link
Contributor

hasura-bot commented May 11, 2020

Beep boop! 🤖

Hey @marekdano, thanks for your PR!

One of my human friends will review this PR and get back to you as soon as possible.

Stay awesome! 😎

@netlify
Copy link

netlify bot commented May 11, 2020 •
edited
Loading

Deploy preview for hasura-docs ready!

Built with commit e386be0

https://deploy-preview-4737--hasura-docs.netlify.app

@beerose beerose self-assigned this May 14, 2020
beerose
beerose suggested changes May 18, 2020
View reviewed changes
Copy link
Contributor

@beerose beerose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR! 🎉

Left some comments.

beerose
beerose reviewed May 18, 2020
View reviewed changes
@hasura-bot
Copy link
Contributor

hasura-bot commented May 18, 2020

Review app for commit e386be0 deployed to Heroku: https://hge-ci-pull-4737.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4737-e386be04

@beerose beerose mentioned this pull request May 29, 2020
Closed
46 tasks
@hasura-bot
Copy link
Contributor

hasura-bot commented Jun 6, 2020

Review app for commit ddbc47a deployed to Heroku: https://hge-ci-pull-4737.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4737-ddbc47a6

@beerose beerose requested a review from rikinsk June 6, 2020 08:43
@beerose beerose assigned rikinsk and unassigned beerose Jun 6, 2020
@rikinsk rikinsk assigned beerose and unassigned rikinsk Jun 9, 2020
@beerose beerose changed the title Migrate Telemetry to TS. console: migrate telemetry to typescript Jun 9, 2020
@hasura-bot
Copy link
Contributor

hasura-bot commented Jun 9, 2020

Review app for commit 78ec077 deployed to Heroku: https://hge-ci-pull-4737.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4737-78ec077d

@beerose beerose merged commit fa60c7d into hasura:master Jun 9, 2020
@hasura-bot
Copy link
Contributor

hasura-bot commented Jun 9, 2020

Review app https://hge-ci-pull-4737.herokuapp.com is deleted

@hasura-bot
Copy link
Contributor

hasura-bot commented Jun 9, 2020

Beep boop! 🤖

GIF

Awesome work @marekdano! All of us at Hasura ❤️ what you did.

Thanks again 🤗

beerose pushed a commit that referenced this pull request Jun 9, 2020
@marekdano
console: migrate telemetry to typescript (#4737)
ba2f32b
stevefan1999-personal pushed a commit to stevefan1999-personal/graphql-engine that referenced this pull request Sep 12, 2020
@marekdano @stevefan1999-personal
console: migrate telemetry to typescript (hasura#4737)
37a325f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rikinsk rikinsk rikinsk approved these changes

+1 more reviewer

@beerose beerose beerose approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@beerose beerose

Labels

c/console Related to console community-contrib 🙏🏽 no-changelog-required typescript-migration 🙌

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@marekdano @hasura-bot @beerose @rikinsk