这是indexloc提供的服务，不要输入任何密码
Skip to content

console: handle generated and identity columns in console data section (close #4552, #4863) #4761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 25 commits into from
Jul 2, 2020
Merged

console: handle generated and identity columns in console data section (close #4552, #4863) #4761

merged 25 commits into from
Jul 2, 2020

Conversation

@beerose
Copy link
Contributor

@beerose beerose commented May 13, 2020 •
edited by rikinsk
Loading

Solves #4552, #4863

Description

If is_generated is set to true, editing a column is disabled in the console in Edit Row and Insert Row sections.

I also did a small refactor and moved code that was shared between EditRow and InsertRow to the separate component.

Changelog

  • CHANGELOG.md is updated with user-facing content relevant to this PR.

Affected components

  • Console

@beerose beerose added the c/console Related to console label May 13, 2020
@hasura-bot
Copy link
Contributor

hasura-bot commented May 13, 2020

Review app for commit b42cb77 deployed to Heroku: https://hge-ci-pull-4761.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4761-b42cb776

@hasura-bot
Copy link
Contributor

hasura-bot commented May 13, 2020

Review app for commit 026ac56 deployed to Heroku: https://hge-ci-pull-4761.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4761-026ac56c

@hasura-bot
Copy link
Contributor

hasura-bot commented May 13, 2020

Review app for commit 406f6c9 deployed to Heroku: https://hge-ci-pull-4761.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4761-406f6c94

@hasura-bot
Copy link
Contributor

hasura-bot commented May 13, 2020

Review app for commit 33794c0 deployed to Heroku: https://hge-ci-pull-4761.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4761-33794c0f

@hasura-bot
Copy link
Contributor

hasura-bot commented Jun 9, 2020

Review app for commit 3526e2b deployed to Heroku: https://hge-ci-pull-4761.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4761-3526e2b5

@beerose beerose mentioned this pull request Jun 10, 2020
Closed
@netlify
Copy link

netlify bot commented Jun 11, 2020 •
edited
Loading

Deploy preview for hasura-docs ready!

Built with commit 992b8a0

https://deploy-preview-4761--hasura-docs.netlify.app

@hasura-bot
Copy link
Contributor

hasura-bot commented Jun 11, 2020

Review app for commit 77c8048 deployed to Heroku: https://hge-ci-pull-4761.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4761-77c80486

@beerose beerose changed the title console: handle generated columns in console data section console: handle generated columns in console data section (close #4552, #4863) Jun 11, 2020
@beerose beerose changed the title console: handle generated columns in console data section (close #4552, #4863) console: handle generated and identity columns in console data section (close #4552, #4863) Jun 11, 2020
@beerose beerose marked this pull request as ready for review June 11, 2020 15:31
@beerose beerose requested review from a team as code owners June 11, 2020 15:31
tirumaraiselvan
tirumaraiselvan reviewed Jun 11, 2020
View reviewed changes
@tirumaraiselvan
Update CHANGELOG.md
446e249 
Co-authored-by: Tirumarai Selvan <tirumarai.selvan@gmail.com>
beerose
beerose commented Jun 11, 2020
View reviewed changes
rikinsk
rikinsk requested changes Jun 16, 2020
View reviewed changes
Copy link
Member

@rikinsk rikinsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@beerose I am seeing an error while trying to edit a row of a table which has a generated always type column. generated by default seems to work.

Table def:

CREATE TABLE people_identity_always (
    id integer primary key generated always as identity,
    name text
);

Screenshot from 2020-06-16 18-02-08

https://hge-ci-pull-4761.herokuapp.com/console/data/schema/public/tables/people_identity_always/browse

@rikinsk rikinsk assigned beerose and unassigned rikinsk Jun 16, 2020
@hasura-bot
Copy link
Contributor

hasura-bot commented Jun 20, 2020

Review app for commit 4ab7d65 deployed to Heroku: https://hge-ci-pull-4761.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4761-4ab7d655

@hasura-bot
Copy link
Contributor

hasura-bot commented Jun 20, 2020

Review app for commit a1e5cc9 deployed to Heroku: https://hge-ci-pull-4761.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4761-a1e5cc96

@beerose
Copy link
Contributor Author

beerose commented Jun 20, 2020

@rikinsk yes, I missed slight difference in the behaviour between always and by default. Should be fixed now.

@rikinsk rikinsk requested a review from soorajshankar June 23, 2020 11:47
@rikinsk rikinsk assigned soorajshankar and unassigned beerose Jun 23, 2020
soorajshankar
soorajshankar requested changes Jun 24, 2020
View reviewed changes
Copy link
Member

@soorajshankar soorajshankar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good!
left a small review comment

Tested with PG v12 locally working as expected.

@hasura-bot
Copy link
Contributor

hasura-bot commented Jun 25, 2020

Review app for commit d0d6dd3 deployed to Heroku: https://hge-ci-pull-4761.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4761-d0d6dd3e

@hasura-bot
Copy link
Contributor

hasura-bot commented Jul 2, 2020

Review app for commit 55b7d16 deployed to Heroku: https://hge-ci-pull-4761.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4761-55b7d166

@rikinsk rikinsk merged commit 53a40bc into hasura:master Jul 2, 2020
@hasura-bot
Copy link
Contributor

hasura-bot commented Jul 2, 2020

Review app https://hge-ci-pull-4761.herokuapp.com is deleted

@beerose beerose deleted the generated-columns branch July 2, 2020 09:13
stevefan1999-personal pushed a commit to stevefan1999-personal/graphql-engine that referenced this pull request Sep 12, 2020
@stevefan1999-personal
console: handle generated and identity columns in console data section (
a5773c0 
close hasura#4552, hasura#4863) (hasura#4761)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@soorajshankar soorajshankar soorajshankar approved these changes

@tirumaraiselvan tirumaraiselvan tirumaraiselvan approved these changes

@rikinsk rikinsk rikinsk approved these changes

Assignees

@beerose beerose

Labels

c/console Related to console

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@beerose @hasura-bot @soorajshankar @tirumaraiselvan @rikinsk