这是indexloc提供的服务，不要输入任何密码
Skip to content

Convert Container.js to TypeScript #4724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
May 27, 2020
Merged

Convert Container.js to TypeScript #4724

merged 5 commits into from
May 27, 2020

Conversation

@ryands17
Copy link
Contributor

@ryands17 ryands17 commented May 10, 2020

Affected components

  • Console

Related Issues

#4314 (comment)

Solution and Design

Limitations, known bugs & workarounds

  • The types for the state are best addressed in the State.js file directly on converting to TypeScript which is why currently I have provided only the base types.

Breaking changes

  • No Breaking changes

@ryands17 ryands17 requested a review from a team as a code owner May 10, 2020 15:53
@hasura-bot
Copy link
Contributor

hasura-bot commented May 10, 2020

Beep boop! 🤖

Hey @ryands17, thanks for your PR!

One of my human friends will review this PR and get back to you as soon as possible.

Stay awesome! 😎

@hasura-bot
Copy link
Contributor

hasura-bot commented May 10, 2020

Review app for commit 1577b64 deployed to Heroku: https://hge-ci-pull-4724.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4724-1577b648

@beerose beerose mentioned this pull request May 14, 2020
Closed
46 tasks
@ryands17 ryands17 force-pushed the feature/ts-settings-container branch from 1577b64 to 6b997e4 Compare May 17, 2020 10:29
@hasura-bot
Copy link
Contributor

hasura-bot commented May 17, 2020

Review app for commit 6b997e4 deployed to Heroku: https://hge-ci-pull-4724.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4724-6b997e48

beerose
beerose suggested changes May 18, 2020
View reviewed changes
Copy link
Contributor

@beerose beerose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR! 🎉

Left some minor comments.

@netlify
Copy link

netlify bot commented May 18, 2020 •
edited
Loading

Deploy preview for hasura-docs ready!

Built with commit 0d375a5

https://deploy-preview-4724--hasura-docs.netlify.app

@hasura-bot
Copy link
Contributor

hasura-bot commented May 25, 2020

Review app for commit f26c10e deployed to Heroku: https://hge-ci-pull-4724.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4724-f26c10e5

@beerose beerose self-requested a review May 25, 2020 11:03
@hasura-bot
Copy link
Contributor

hasura-bot commented May 25, 2020

Review app for commit 0d375a5 deployed to Heroku: https://hge-ci-pull-4724.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4724-0d375a54

@beerose beerose requested a review from rikinsk May 26, 2020 09:40
@rikinsk rikinsk merged commit b088db6 into hasura:master May 27, 2020
@hasura-bot
Copy link
Contributor

hasura-bot commented May 27, 2020

Beep boop! 🤖

GIF

Awesome work @ryands17! All of us at Hasura ❤️ what you did.

Thanks again 🤗

@hasura-bot
Copy link
Contributor

hasura-bot commented May 27, 2020

Review app https://hge-ci-pull-4724.herokuapp.com is deleted

stevefan1999-personal pushed a commit to stevefan1999-personal/graphql-engine that referenced this pull request Sep 12, 2020
@ryands17 @stevefan1999-personal
console: migrate Container.js to TypeScript (hasura#4724)
9bdaa90
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rikinsk rikinsk rikinsk approved these changes

+1 more reviewer

@beerose beerose beerose approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@rikinsk rikinsk

Labels

c/console Related to console community-contrib 🙏🏽 no-changelog-required typescript-migration 🙌

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ryands17 @hasura-bot @beerose @rikinsk @marionschleifer