console: optimise count fetch in data browser #4692
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coco98
approved these changes
May 6, 2020
beerose
approved these changes
May 6, 2020
Contributor
|
Review app for commit 436176c deployed to Heroku: https://hge-ci-pull-4692.herokuapp.com |
wawhal
approved these changes
May 6, 2020
Contributor
|
Review app https://hge-ci-pull-4692.herokuapp.com is deleted |
rikinsk
added a commit
to rikinsk/graphql-engine
that referenced
this pull request
May 6, 2020
* in table-browse-rows, make intelligent count * update changelog * simplify getting estimatedCount * prevent doubled requests * hide estimated count * update changelog * Update CHANGELOG.md Co-authored-by: Rishichandra Wawhal <rishi@hasura.io> Co-authored-by: Aleksandra Sikora <ola.zxcvbnm@gmail.com>
coco98
pushed a commit
that referenced
this pull request
May 6, 2020
* in table-browse-rows, make intelligent count * update changelog * simplify getting estimatedCount * prevent doubled requests * hide estimated count * update changelog * Update CHANGELOG.md Co-authored-by: Rishichandra Wawhal <rishi@hasura.io> Co-authored-by: Aleksandra Sikora <ola.zxcvbnm@gmail.com> Co-authored-by: Rishichandra Wawhal <rishi@hasura.io> Co-authored-by: Aleksandra Sikora <ola.zxcvbnm@gmail.com>
9 tasks
stevefan1999-personal
pushed a commit
to stevefan1999-personal/graphql-engine
that referenced
this pull request
Sep 12, 2020
* in table-browse-rows, make intelligent count * update changelog * simplify getting estimatedCount * prevent doubled requests * hide estimated count * update changelog * Update CHANGELOG.md Co-authored-by: Rishichandra Wawhal <rishi@hasura.io> Co-authored-by: Aleksandra Sikora <ola.zxcvbnm@gmail.com>
karthikvt26
pushed a commit
to karthikvt26/graphql-engine
that referenced
this pull request
Nov 17, 2020
) * in table-browse-rows, make intelligent count * update changelog * simplify getting estimatedCount * prevent doubled requests * hide estimated count * update changelog * Update CHANGELOG.md Co-authored-by: Rishichandra Wawhal <rishi@hasura.io> Co-authored-by: Aleksandra Sikora <ola.zxcvbnm@gmail.com> Co-authored-by: Rishichandra Wawhal <rishi@hasura.io> Co-authored-by: Aleksandra Sikora <ola.zxcvbnm@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changelog
CHANGELOG.mdis updated with user-facing content relevant to this PR.Affected components
Related Issues
Solution and Design
Steps to test and verify
Limitations, known bugs & workarounds