这是indexloc提供的服务，不要输入任何密码
Skip to content

console: migrate sidebar to typescript #4690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Jun 9, 2020
Merged

console: migrate sidebar to typescript #4690

merged 10 commits into from
Jun 9, 2020

Conversation

@marekdano
Copy link
Contributor

@marekdano marekdano commented May 6, 2020

Description

Migrate Sidebar to TS. The PR relates to #4314

Changelog

  • CHANGELOG.md is updated with user-facing content relevant to this PR.

Affected components

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System
  • Tests
  • Other (list it)

Catalog upgrade

Does this PR change Hasura Catalog version?

  • No
  • Yes
    • Updated docs with SQL for downgrading the catalog

Metadata

Does this PR add a new Metadata feature?

  • No
  • Yes
    • Does run_sql auto manages the new metadata through schema diffing?
      • Yes
      • Not required
    • Does run_sql auto manages the definitions of metadata on renaming?
      • Yes
      • Not required
    • Does export_metadata/replace_metadata supports the new metadata added?
      • Yes
      • Not required

GraphQL

  • No new GraphQL schema is generated
  • New GraphQL schema is being generated:
    • New types and typenames are correlated

Breaking changes

  • No Breaking changes
  • There are breaking changes:

@marekdano marekdano requested a review from a team as a code owner May 6, 2020 12:38
@hasura-bot
Copy link
Contributor

hasura-bot commented May 6, 2020

Beep boop! 🤖

Hey @marekdano, thanks for your PR!

One of my human friends will review this PR and get back to you as soon as possible.

Stay awesome! 😎

@beerose beerose self-assigned this May 8, 2020
beerose
beerose suggested changes May 8, 2020
View reviewed changes
Copy link
Contributor

@beerose beerose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR! 🎉

Left a few comments.

@netlify
Copy link

netlify bot commented May 8, 2020 •
edited
Loading

Deploy preview for hasura-docs ready!

Built with commit f7cb3c1

https://deploy-preview-4690--hasura-docs.netlify.app

@beerose beerose mentioned this pull request May 14, 2020
Closed
46 tasks
@hasura-bot
Copy link
Contributor

hasura-bot commented Jun 5, 2020

Review app for commit 342c017 deployed to Heroku: https://hge-ci-pull-4690.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4690-342c017d

@beerose beerose requested a review from rikinsk June 6, 2020 07:58
@beerose beerose assigned rikinsk and unassigned beerose Jun 6, 2020
@hasura-bot
Copy link
Contributor

hasura-bot commented Jun 8, 2020

Review app for commit e4ff1ba deployed to Heroku: https://hge-ci-pull-4690.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4690-e4ff1bad

@rikinsk rikinsk assigned beerose and unassigned rikinsk Jun 9, 2020
@beerose beerose changed the title Migrate sidebar to ts console: migrate sidebar to typescript Jun 9, 2020
@beerose beerose merged commit 9b2d46c into hasura:master Jun 9, 2020
@hasura-bot
Copy link
Contributor

hasura-bot commented Jun 9, 2020

Beep boop! 🤖

GIF

Awesome work @marekdano! All of us at Hasura ❤️ what you did.

Thanks again 🤗

@hasura-bot
Copy link
Contributor

hasura-bot commented Jun 9, 2020

Review app https://hge-ci-pull-4690.herokuapp.com is deleted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rikinsk rikinsk rikinsk approved these changes

+1 more reviewer

@beerose beerose beerose approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@beerose beerose

Labels

c/console Related to console community-contrib 🙏🏽 no-changelog-required typescript-migration 🙌

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@marekdano @hasura-bot @beerose @rikinsk