这是indexloc提供的服务，不要输入任何密码
Skip to content

console: migrate CollapsibleToggle to typescript #4697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
May 29, 2020
Merged

console: migrate CollapsibleToggle to typescript #4697

merged 6 commits into from
May 29, 2020

Conversation

@kshitijk83
Copy link
Contributor

@kshitijk83 kshitijk83 commented May 7, 2020

Description

This pull request convert CollapsibleToggle component to typescript

Changelog

  • CHANGELOG.md is updated with user-facing content relevant to this PR.

Affected components

  • Console

Related Issues

#4314

Solution and Design

added state and props interfaces:

interface CollapsibleToggleProps {
  title: string;
  isOpen: boolean;
  toggleHandler?: () => void;
  testId: string;
  children: React.ReactNode;
  useDefaultTitleStyle?: boolean;
}

interface CollapsibleToggleState {
  isOpen: boolean;
  toggleHandler: () => void;
}

Server checklist

Catalog upgrade

Does this PR change Hasura Catalog version?

  • No
  • Yes
    • Updated docs with SQL for downgrading the catalog

Metadata

Does this PR add a new Metadata feature?

  • No
  • Yes
    • Does run_sql auto manages the new metadata through schema diffing?
      • Yes
      • Not required
    • Does run_sql auto manages the definitions of metadata on renaming?
      • Yes
      • Not required
    • Does export_metadata/replace_metadata supports the new metadata added?
      • Yes
      • Not required

GraphQL

  • No new GraphQL schema is generated
  • New GraphQL schema is being generated:
    • New types and typenames are correlated

Breaking changes

  • No Breaking changes
  • There are breaking changes:

@kshitijk83 kshitijk83 requested a review from a team as a code owner May 7, 2020 04:00
@hasura-bot
Copy link
Contributor

hasura-bot commented May 7, 2020

Beep boop! 🤖

Hey @kshitijk83, thanks for your PR!

One of my human friends will review this PR and get back to you as soon as possible.

Stay awesome! 😎

@CLAassistant
Copy link

CLAassistant commented May 7, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@hasura-bot
Copy link
Contributor

hasura-bot commented May 7, 2020

Review app for commit b9e1486 deployed to Heroku: https://hge-ci-pull-4697.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4697-b9e14869

beerose
beerose suggested changes May 8, 2020
View reviewed changes
Copy link
Contributor

@beerose beerose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your PR!

I left one comment and also I noticed some eslint issues, for example with global require or missing role attribute. Could you take a look? You can check for lint errors by running npm run lint.

@netlify
Copy link

netlify bot commented May 8, 2020 •
edited
Loading

Deploy preview for hasura-docs ready!

Built with commit d270345

https://deploy-preview-4697--hasura-docs.netlify.app

@kshitijk83 kshitijk83 requested a review from beerose May 8, 2020 16:14
@hasura-bot
Copy link
Contributor

hasura-bot commented May 8, 2020

Review app for commit 9491718 deployed to Heroku: https://hge-ci-pull-4697.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4697-94917183

@beerose beerose mentioned this pull request May 14, 2020
Closed
46 tasks
@hasura-bot
Copy link
Contributor

hasura-bot commented May 25, 2020

Review app for commit d270345 deployed to Heroku: https://hge-ci-pull-4697.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4697-d2703459

@kshitijk83 kshitijk83 closed this May 28, 2020
@hasura-bot
Copy link
Contributor

hasura-bot commented May 28, 2020

Review app https://hge-ci-pull-4697.herokuapp.com is deleted

@kshitijk83 kshitijk83 reopened this May 28, 2020
@kshitijk83
Copy link
Contributor Author

kshitijk83 commented May 28, 2020

@beerose are there any required changes left?

@beerose
Copy link
Contributor

beerose commented May 28, 2020

@beerose are there any required changes left?

No, I just approved 🙂
Thanks again for your PR!

@hasura-bot
Copy link
Contributor

hasura-bot commented May 28, 2020

Review app for commit a177b39 deployed to Heroku: https://hge-ci-pull-4697.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4697-a177b39a

@beerose beerose changed the title Collapsible Toggle to typescript close #4314 console: migrate CollapsibleToggle to typescript May 28, 2020
@beerose beerose requested a review from rikinsk May 29, 2020 11:33
@hasura-bot
Copy link
Contributor

hasura-bot commented May 29, 2020

Review app for commit 462e2d7 deployed to Heroku: https://hge-ci-pull-4697.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4697-462e2d7d

@hasura-bot
Copy link
Contributor

hasura-bot commented May 29, 2020

Review app for commit 9863934 deployed to Heroku: https://hge-ci-pull-4697.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4697-98639349

@rikinsk rikinsk merged commit a2a492e into hasura:master May 29, 2020
@hasura-bot
Copy link
Contributor

hasura-bot commented May 29, 2020

Beep boop! 🤖

GIF

Awesome work @kshitijk83! All of us at Hasura ❤️ what you did.

Thanks again 🤗

@hasura-bot
Copy link
Contributor

hasura-bot commented May 29, 2020

Review app https://hge-ci-pull-4697.herokuapp.com is deleted

stevefan1999-personal pushed a commit to stevefan1999-personal/graphql-engine that referenced this pull request Sep 12, 2020
@kshitijk83 @stevefan1999-personal
console: migrate CollapsibleToggle to TS (hasura#4697)
ca8b5d1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rikinsk rikinsk rikinsk approved these changes

+1 more reviewer

@beerose beerose beerose approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c/console Related to console community-contrib 🙏🏽 no-changelog-required typescript-migration 🙌

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@kshitijk83 @hasura-bot @CLAassistant @beerose @rikinsk @marionschleifer