docs: fix wrong info of excluding scheme in CORS config #4685
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for hasura-docs ready! Built with commit ecc61e9 |
marionschleifer
approved these changes
May 7, 2020
rikinsk
requested changes
May 8, 2020
Member
rikinsk
left a comment
There was a problem hiding this comment.
@ecthiender Hey. Could you move the changelog line to the Next release section instead of the 1.2.0 section. (Would have done it myself but I cant seem to be able to edit the file on gihub)
Contributor
Author
|
@rikinsk thanks for catching it! Moved it to "Next Release" 👍 |
rikinsk
approved these changes
May 11, 2020
Contributor
|
Review app https://hge-ci-pull-4685.herokuapp.com is deleted |
rikinsk
pushed a commit
that referenced
this pull request
May 12, 2020
stevefan1999-personal
pushed a commit
to stevefan1999-personal/graphql-engine
that referenced
this pull request
Sep 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix wrong info about excluding scheme in CORS config in docs.
Changelog
CHANGELOG.mdis updated with user-facing content relevant to this PR.Affected components
Related Issues
N/A
Solution and Design
N/A
Steps to test and verify
N/A
Limitations, known bugs & workarounds
N/A
Server checklist
N/A