这是indexloc提供的服务，不要输入任何密码
Skip to content

console: convert settings/utils to typescript #4684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jun 10, 2020
Merged

console: convert settings/utils to typescript #4684

merged 8 commits into from
Jun 10, 2020

Conversation

@poul-kg
Copy link
Contributor

@poul-kg poul-kg commented May 6, 2020

Affected components

  • Console

Related Issues

References #4314

Solution and Design

First try to convert .js to .ts need a feedback if something is not per expectations.

@poul-kg poul-kg requested a review from a team as a code owner May 6, 2020 09:30
@hasura-bot
Copy link
Contributor

hasura-bot commented May 6, 2020

Beep boop! 🤖

Hey @poul-kg, thanks for your PR!

One of my human friends will review this PR and get back to you as soon as possible.

Stay awesome! 😎

@CLAassistant
Copy link

CLAassistant commented May 6, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@hasura-bot
Copy link
Contributor

hasura-bot commented May 6, 2020

Review app for commit 1795687 deployed to Heroku: https://hge-ci-pull-4684.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4684-17956875

@beerose beerose self-assigned this May 8, 2020
@beerose beerose mentioned this pull request May 14, 2020
Closed
46 tasks
beerose
beerose suggested changes May 15, 2020
View reviewed changes
Copy link
Contributor

@beerose beerose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR! 🎉

I left some minor comments.

Also, I see there is an eslint error Unexpected lexical declaration in case block.
Could you disable rule: no-case-declarations in .eslintrc in TypeScript overrides section?

@netlify
Copy link

netlify bot commented May 22, 2020 •
edited
Loading

Deploy preview for hasura-docs ready!

Built with commit cbbd9c4

https://deploy-preview-4684--hasura-docs.netlify.app

@poul-kg poul-kg force-pushed the console-utils-ts branch from cbbd9c4 to a589c74 Compare May 22, 2020 09:08
@poul-kg
Copy link
Contributor Author

poul-kg commented May 22, 2020

upgraded my forked master branch with current graphql-engine/master, and rebased my branch onto master so everything is in sync.

@hasura-bot
Copy link
Contributor

hasura-bot commented Jun 5, 2020

Review app for commit fbcc4af deployed to Heroku: https://hge-ci-pull-4684.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4684-fbcc4af7

@beerose beerose requested a review from rikinsk June 6, 2020 07:58
@beerose beerose assigned rikinsk and unassigned beerose Jun 6, 2020
@hasura-bot
Copy link
Contributor

hasura-bot commented Jun 8, 2020

Review app for commit 4e80aed deployed to Heroku: https://hge-ci-pull-4684.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4684-4e80aed4

@rikinsk rikinsk assigned beerose and unassigned rikinsk Jun 9, 2020
@hasura-bot
Copy link
Contributor

hasura-bot commented Jun 10, 2020

Review app for commit d98f0e0 deployed to Heroku: https://hge-ci-pull-4684.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4684-d98f0e00

@beerose beerose changed the title console: convert Settings/utils.js to utils.ts console: convert settings/utils to typescript Jun 10, 2020
@beerose beerose merged commit 2030da5 into hasura:master Jun 10, 2020
@hasura-bot
Copy link
Contributor

hasura-bot commented Jun 10, 2020

Beep boop! 🤖

GIF

Awesome work @poul-kg! All of us at Hasura ❤️ what you did.

Thanks again 🤗

@hasura-bot
Copy link
Contributor

hasura-bot commented Jun 10, 2020

Review app https://hge-ci-pull-4684.herokuapp.com is deleted

beerose pushed a commit that referenced this pull request Jun 10, 2020
@poul-kg
console: convert settings/utils to typescript (#4684)
74a208a
@marionschleifer
Copy link
Contributor

marionschleifer commented Jun 15, 2020

@poul-kg thanks a lot for your contribution 🙏 as a thank you, we'd love to send you some swag. If you're interested, please send an email to marion@hasura.io and we'll take it from there 🙂

stevefan1999-personal pushed a commit to stevefan1999-personal/graphql-engine that referenced this pull request Sep 12, 2020
@poul-kg @stevefan1999-personal
console: convert settings/utils to typescript (hasura#4684)
cdfd9ba
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rikinsk rikinsk rikinsk approved these changes

+1 more reviewer

@beerose beerose beerose approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@beerose beerose

Labels

c/console Related to console community-contrib 🙏🏽 no-changelog-required typescript-migration 🙌

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@poul-kg @hasura-bot @CLAassistant @marionschleifer @beerose @rikinsk