这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@wawhal
Copy link
Contributor

@wawhal wawhal commented May 6, 2020

Description

Currently

On the browse rows page, console makes two concurrent queries:

  1. A query to fetch the first 10 rows and make an estimated count
  2. A query to get exact count

This query to get exact count overloads the database if the the table has large amount of data.

Fix

The browse rows page makes:

  1. A query to fetch the first 10 rows and make an estimated count
  2. If the estimated count is greater than 100000, the count is not shown (as the estimated count doesnt yet account for filters) and the pagination is rendered based on the estimated count.
  3. If the estimated coutn is less than 100000, a query is made to fetch the exact count asynchronously. Until the exact count is fetched, the UI is rendered based on the estimated count.

Changelog

  • CHANGELOG.md is updated with user-facing content relevant to this PR.

Affected components

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System
  • Tests
  • Other (list it)

Related Issues

@wawhal wawhal requested a review from a team as a code owner May 6, 2020 06:01
@wawhal wawhal requested a review from a team as a code owner May 6, 2020 06:04
@hasura-bot
Copy link
Contributor

Review app for commit e4d3469 deployed to Heroku: https://hge-ci-pull-4681.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4681-e4d3469e

@rikinsk rikinsk added the c/console Related to console label May 6, 2020
@beerose beerose requested a review from rikinsk May 6, 2020 09:20
@hasura-bot
Copy link
Contributor

Review app for commit da2aea1 deployed to Heroku: https://hge-ci-pull-4681.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4681-da2aea1b

@hasura-bot
Copy link
Contributor

Review app for commit dc17fe5 deployed to Heroku: https://hge-ci-pull-4681.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4681-dc17fe5a

@rikinsk
Copy link
Member

rikinsk commented May 7, 2020

Subsumed in #4692

@rikinsk rikinsk closed this May 7, 2020
@hasura-bot
Copy link
Contributor

Review app https://hge-ci-pull-4681.herokuapp.com is deleted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c/console Related to console

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants