这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@fkhadra
Copy link
Contributor

@fkhadra fkhadra commented May 5, 2020

Description

Hey,

This PR allows changing the default value for a Primary key when editing the column. I also added a cypress test for that.

Changelog

  • CHANGELOG.md is updated with user-facing content relevant to this PR.

Affected components

  • Console

Related Issues

Related issue #4075

Catalog upgrade

Does this PR change Hasura Catalog version?

  • No

Metadata

  • No

Does this PR add a new Metadata feature?

  • No

GraphQL

  • No new GraphQL schema is generated

Breaking changes

  • No Breaking changes

@fkhadra fkhadra requested a review from a team as a code owner May 5, 2020 20:26
@hasura-bot
Copy link
Contributor

Beep boop! 🤖

Hey @fkhadra, thanks for your PR!

One of my human friends will review this PR and get back to you as soon as possible.

Stay awesome! 😎

@hasura-bot
Copy link
Contributor

Review app for commit 2f2386c deployed to Heroku: https://hge-ci-pull-4679.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4679-2f2386ce

Copy link
Contributor

@beerose beerose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR!

Code looks good, approving.

@netlify
Copy link

netlify bot commented May 8, 2020

Deploy preview for hasura-docs ready!

Built with commit 9d01094

https://deploy-preview-4679--hasura-docs.netlify.app

@hasura-bot
Copy link
Contributor

Review app for commit c8a0a30 deployed to Heroku: https://hge-ci-pull-4679.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4679-c8a0a303

group console notes together

Co-authored-by: Aleksandra Sikora <ola.zxcvbnm@gmail.com>
@fkhadra fkhadra requested a review from a team as a code owner May 8, 2020 13:25
@fkhadra
Copy link
Contributor Author

fkhadra commented May 8, 2020

Updated :)

@hasura-bot
Copy link
Contributor

Review app for commit 5aadfe9 deployed to Heroku: https://hge-ci-pull-4679.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4679-5aadfe9a

@hasura-bot
Copy link
Contributor

Review app for commit e336239 deployed to Heroku: https://hge-ci-pull-4679.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4679-e3362398

@hasura-bot
Copy link
Contributor

Review app for commit 9d01094 deployed to Heroku: https://hge-ci-pull-4679.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4679-9d010946

@rikinsk rikinsk merged commit cd1c562 into hasura:master May 12, 2020
@hasura-bot
Copy link
Contributor

Review app https://hge-ci-pull-4679.herokuapp.com is deleted

@hasura-bot
Copy link
Contributor

Beep boop! 🤖

GIF

Awesome work @fkhadra! All of us at Hasura ❤️ what you did.

Thanks again 🤗

stevefan1999-personal pushed a commit to stevefan1999-personal/graphql-engine that referenced this pull request Sep 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants