这是indexloc提供的服务，不要输入任何密码
Skip to content

console: migrate HTML helpers, route hooks helpers and version utils to TypeScript #4641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
May 14, 2020
Merged

console: migrate HTML helpers, route hooks helpers and version utils to TypeScript #4641

merged 11 commits into from
May 14, 2020

Conversation

@ryands17
Copy link
Contributor

@ryands17 ryands17 commented May 1, 2020

Description

Affected components

  • Console

Related Issues

#4314 (comment)

Solution and Design

  • Converted the componens HTML helpers, Route Hooks Helpers and Version Utils to their respective TypeScript modules.

Breaking changes

  • No Breaking changes

@ryands17 ryands17 requested a review from a team as a code owner May 1, 2020 14:37
@hasura-bot
Copy link
Contributor

hasura-bot commented May 1, 2020

Beep boop! 🤖

Hey @ryands17, thanks for your PR!

One of my human friends will review this PR and get back to you as soon as possible.

Stay awesome! 😎

@CLAassistant
Copy link

CLAassistant commented May 1, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@netlify
Copy link

netlify bot commented May 1, 2020 •
edited
Loading

Deploy preview for hasura-docs ready!

Built with commit 301b090

https://deploy-preview-4641--hasura-docs.netlify.app

@hasura-bot
Copy link
Contributor

hasura-bot commented May 1, 2020

Review app for commit 888cc31 deployed to Heroku: https://hge-ci-pull-4641.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4641-888cc310

@hasura-bot
Copy link
Contributor

hasura-bot commented May 1, 2020

Review app for commit 11636bf deployed to Heroku: https://hge-ci-pull-4641.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4641-11636bfb

beerose
beerose suggested changes May 5, 2020
View reviewed changes
Copy link
Contributor

@beerose beerose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR! 🎉

Left some minor comments. Overall looks great!

@hasura-bot
Copy link
Contributor

hasura-bot commented May 6, 2020

Review app for commit 301b090 deployed to Heroku: https://hge-ci-pull-4641.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4641-301b0908

@ryands17
Copy link
Contributor Author

ryands17 commented May 6, 2020

Hey @beerose 👋
Updated the PR with the above suggestions :)

beerose
beerose reviewed May 11, 2020
View reviewed changes
@beerose beerose changed the title Feature/ts migrate console: migrate HTML helpers, route hooks helpers and version utils to TypeScript May 11, 2020
beerose
beerose reviewed May 11, 2020
View reviewed changes
@hasura-bot
Copy link
Contributor

hasura-bot commented May 11, 2020

Review app for commit 1bb45c1 deployed to Heroku: https://hge-ci-pull-4641.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4641-1bb45c13

@hasura-bot
Copy link
Contributor

hasura-bot commented May 14, 2020

Review app for commit b79bd2f deployed to Heroku: https://hge-ci-pull-4641.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4641-b79bd2f6

@hasura-bot
Copy link
Contributor

hasura-bot commented May 14, 2020

Review app for commit 0bbbf9d deployed to Heroku: https://hge-ci-pull-4641.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4641-0bbbf9dd

@beerose beerose mentioned this pull request May 14, 2020
Closed
46 tasks
@rikinsk rikinsk merged commit 619d167 into hasura:master May 14, 2020
@hasura-bot
Copy link
Contributor

hasura-bot commented May 14, 2020

Beep boop! 🤖

GIF

Awesome work @ryands17! All of us at Hasura ❤️ what you did.

Thanks again 🤗

@hasura-bot
Copy link
Contributor

hasura-bot commented May 14, 2020

Review app https://hge-ci-pull-4641.herokuapp.com is deleted

stevefan1999-personal pushed a commit to stevefan1999-personal/graphql-engine that referenced this pull request Sep 12, 2020
@ryands17 @stevefan1999-personal
console: migrate HTML helpers, route hooks helpers and version utils …
953e792 
…to TypeScript (hasura#4641)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rikinsk rikinsk rikinsk approved these changes

+1 more reviewer

@beerose beerose beerose approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@rikinsk rikinsk

Labels

c/console Related to console community-contrib 🙏🏽 no-changelog-required typescript-migration 🙌

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@ryands17 @hasura-bot @CLAassistant @beerose @rikinsk @marionschleifer