这是indexloc提供的服务，不要输入任何密码
Skip to content

Migrate Globals to ts #4587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Jun 6, 2020
Merged

Migrate Globals to ts #4587

merged 11 commits into from
Jun 6, 2020

Conversation

@marekdano
Copy link
Contributor

@marekdano marekdano commented Apr 28, 2020

Description

This PR migrates Globals to Typescript. I installed highlightjs as a dependency for this project which I'm not sure if it's the right approach.

Changelog

  • CHANGELOG.md is updated with user-facing content relevant to this PR.

Affected components

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System
  • Tests
  • Other (list it)

Related Issues

#4314 console: migrate to TypeScript

Server checklist

Catalog upgrade

Does this PR change Hasura Catalog version?

  • No
  • Yes
    • Updated docs with SQL for downgrading the catalog

Metadata

Does this PR add a new Metadata feature?

  • No
  • Yes
    • Does run_sql auto manages the new metadata through schema diffing?
      • Yes
      • Not required
    • Does run_sql auto manages the definitions of metadata on renaming?
      • Yes
      • Not required
    • Does export_metadata/replace_metadata supports the new metadata added?
      • Yes
      • Not required

GraphQL

  • No new GraphQL schema is generated
  • New GraphQL schema is being generated:
    • New types and typenames are correlated

Breaking changes

  • No Breaking changes
  • There are breaking changes:

@marekdano marekdano requested a review from a team as a code owner April 28, 2020 17:55
@hasura-bot
Copy link
Contributor

hasura-bot commented Apr 28, 2020

Beep boop! 🤖

Hey @marekdano, thanks for your PR!

One of my human friends will review this PR and get back to you as soon as possible.

Stay awesome! 😎

@beerose beerose mentioned this pull request May 14, 2020
Closed
46 tasks
@beerose beerose self-assigned this May 15, 2020
beerose
beerose suggested changes May 18, 2020
View reviewed changes
Copy link
Contributor

@beerose beerose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR! 🎉

I see that build failed. Could you take a look at this? Let me know if you need any help.

@netlify
Copy link

netlify bot commented May 18, 2020 •
edited
Loading

Deploy preview for hasura-docs ready!

Built with commit 6c2eb95

https://deploy-preview-4587--hasura-docs.netlify.app

@hasura-bot
Copy link
Contributor

hasura-bot commented May 18, 2020

Review app for commit 643ff14 deployed to Heroku: https://hge-ci-pull-4587.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4587-643ff144

@marekdano
Copy link
Contributor Author

marekdano commented May 18, 2020

@beerose now the error should be gone.

beerose
beerose suggested changes May 18, 2020
View reviewed changes
@hasura-bot
Copy link
Contributor

hasura-bot commented May 18, 2020

Review app for commit 2bf3616 deployed to Heroku: https://hge-ci-pull-4587.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4587-2bf36169

@hasura-bot
Copy link
Contributor

hasura-bot commented May 25, 2020

Review app for commit 75d72b3 deployed to Heroku: https://hge-ci-pull-4587.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4587-75d72b31

@beerose beerose force-pushed the migrate-globals-to-ts branch from fa06ace to 0dc2daa Compare June 6, 2020 08:58
@hasura-bot
Copy link
Contributor

hasura-bot commented Jun 6, 2020

Review app for commit ea93794 deployed to Heroku: https://hge-ci-pull-4587.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4587-ea93794b

@beerose beerose requested a review from rikinsk June 6, 2020 09:34
@beerose beerose removed their assignment Jun 6, 2020
@hasura-bot
Copy link
Contributor

hasura-bot commented Jun 6, 2020

Review app for commit 6c2eb95 deployed to Heroku: https://hge-ci-pull-4587.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4587-6c2eb952

@rikinsk rikinsk merged commit 20cf05d into hasura:master Jun 6, 2020
@hasura-bot
Copy link
Contributor

hasura-bot commented Jun 6, 2020

Review app https://hge-ci-pull-4587.herokuapp.com is deleted

@hasura-bot
Copy link
Contributor

hasura-bot commented Jun 6, 2020

Beep boop! 🤖

GIF

Awesome work @marekdano! All of us at Hasura ❤️ what you did.

Thanks again 🤗

stevefan1999-personal pushed a commit to stevefan1999-personal/graphql-engine that referenced this pull request Sep 12, 2020
@marekdano @stevefan1999-personal
console: migrate Globals to TS (hasura#4587)
8997480
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rikinsk rikinsk rikinsk approved these changes

+1 more reviewer

@beerose beerose beerose approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c/console Related to console community-contrib 🙏🏽 no-changelog-required typescript-migration 🙌

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@marekdano @hasura-bot @beerose @rikinsk @marionschleifer