这是indexloc提供的服务，不要输入任何密码
Skip to content

Migrate TelemetryFilter file to TS. #4579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
May 14, 2020
Merged

Migrate TelemetryFilter file to TS. #4579

merged 5 commits into from
May 14, 2020

Conversation

@marekdano
Copy link
Contributor

@marekdano marekdano commented Apr 27, 2020

Description

This PR migrates TelemetryFilter to Typescript.

Changelog

  • CHANGELOG.md is updated with user-facing content relevant to this PR.

Affected components

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System
  • Tests
  • Other (list it)

Related Issues

#4314 console: migrate to TypeScript

Server checklist

Catalog upgrade

Does this PR change Hasura Catalog version?

  • No
  • Yes
    • Updated docs with SQL for downgrading the catalog

Metadata

Does this PR add a new Metadata feature?

  • No
  • Yes
    • Does run_sql auto manages the new metadata through schema diffing?
      • Yes
      • Not required
    • Does run_sql auto manages the definitions of metadata on renaming?
      • Yes
      • Not required
    • Does export_metadata/replace_metadata supports the new metadata added?
      • Yes
      • Not required

GraphQL

  • No new GraphQL schema is generated
  • New GraphQL schema is being generated:
    • New types and typenames are correlated

Breaking changes

  • No Breaking changes
  • There are breaking changes:

@marekdano marekdano requested a review from a team as a code owner April 27, 2020 18:33
@hasura-bot
Copy link
Contributor

hasura-bot commented Apr 27, 2020

Beep boop! 🤖

Hey @marekdano, thanks for your PR!

One of my human friends will review this PR and get back to you as soon as possible.

Stay awesome! 😎

@hasura-bot
Copy link
Contributor

hasura-bot commented Apr 27, 2020

Review app for commit 180b840 deployed to Heroku: https://hge-ci-pull-4579.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4579-180b8404

beerose
beerose suggested changes May 4, 2020
View reviewed changes
Copy link
Contributor

@beerose beerose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your PR!

Left some minor comments.

@netlify
Copy link

netlify bot commented May 5, 2020 •
edited
Loading

Deploy preview for hasura-docs ready!

Built with commit 6596d69

https://deploy-preview-4579--hasura-docs.netlify.app

@hasura-bot
Copy link
Contributor

hasura-bot commented May 5, 2020

Review app for commit 75e0ab4 deployed to Heroku: https://hge-ci-pull-4579.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4579-75e0ab41

@beerose beerose self-requested a review May 8, 2020 13:12
@hasura-bot
Copy link
Contributor

hasura-bot commented May 8, 2020

Review app for commit 92f0632 deployed to Heroku: https://hge-ci-pull-4579.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4579-92f06322

@beerose beerose requested a review from rikinsk May 8, 2020 13:43
@hasura-bot
Copy link
Contributor

hasura-bot commented May 14, 2020

Review app for commit 4b0e150 deployed to Heroku: https://hge-ci-pull-4579.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4579-4b0e150e

@rikinsk rikinsk merged commit ced1b4d into hasura:master May 14, 2020
@hasura-bot
Copy link
Contributor

hasura-bot commented May 14, 2020

Review app https://hge-ci-pull-4579.herokuapp.com is deleted

@hasura-bot
Copy link
Contributor

hasura-bot commented May 14, 2020

Beep boop! 🤖

GIF

Awesome work @marekdano! All of us at Hasura ❤️ what you did.

Thanks again 🤗

@beerose beerose mentioned this pull request May 14, 2020
Closed
46 tasks
@marionschleifer
Copy link
Contributor

marionschleifer commented May 18, 2020

@marekdano thank you so much for your contribution 🙏 as a thank you, we'd love to send you some Hasura swag. If you're interested, please send an email to marion@hasura.io and we can take it from there.

stevefan1999-personal pushed a commit to stevefan1999-personal/graphql-engine that referenced this pull request Sep 12, 2020
@marekdano @stevefan1999-personal
console: migrate TelemetryFilter file to TS (hasura#4579)
992b705
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rikinsk rikinsk rikinsk approved these changes

+1 more reviewer

@beerose beerose beerose approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@rikinsk rikinsk

Labels

c/console Related to console community-contrib 🙏🏽 no-changelog-required typescript-migration 🙌

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@marekdano @hasura-bot @marionschleifer @beerose @rikinsk