这是indexloc提供的服务，不要输入任何密码
Skip to content

console: migrate button to TypeScript #4570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 27, 2020
Merged

console: migrate button to TypeScript #4570

merged 4 commits into from
May 27, 2020

Conversation

@kawamataryo
Copy link
Contributor

@kawamataryo kawamataryo commented Apr 26, 2020

Description

Related issue #4314.
Migrated button to TypeScript.

Changelog

  • CHANGELOG.md is updated with user-facing content relevant to this PR.

Affected components

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System
  • Tests
  • Other (list it)

Related Issues

Related issue #4314.

Catalog upgrade

Does this PR change Hasura Catalog version?

  • No
  • Yes

Metadata

Does this PR add a new Metadata feature?

  • No
  • Yes

GraphQL

  • No new GraphQL schema is generated
  • New GraphQL schema is being generated:

Breaking changes

  • No Breaking changes
  • There are breaking changes:

@kawamataryo kawamataryo requested a review from a team as a code owner April 26, 2020 22:35
@hasura-bot
Copy link
Contributor

hasura-bot commented Apr 26, 2020

Beep boop! 🤖

Hey @kawamataryo, thanks for your PR!

One of my human friends will review this PR and get back to you as soon as possible.

Stay awesome! 😎

@hasura-bot
Copy link
Contributor

hasura-bot commented Apr 26, 2020

Review app for commit 0ebd6ac deployed to Heroku: https://hge-ci-pull-4570.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4570-0ebd6ac1

@hasura hasura deleted a comment from akhi5614 Apr 29, 2020
@beerose beerose self-assigned this May 8, 2020
@kawamataryo kawamataryo force-pushed the migrate-button-to-ts branch from 0ebd6ac to 6fc4bef Compare May 9, 2020 23:14
@hasura-bot
Copy link
Contributor

hasura-bot commented May 9, 2020

Review app for commit 6fc4bef deployed to Heroku: https://hge-ci-pull-4570.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4570-6fc4befb

@kawamataryo kawamataryo force-pushed the migrate-button-to-ts branch from 6fc4bef to 1a020d3 Compare May 10, 2020 05:56
@hasura-bot
Copy link
Contributor

hasura-bot commented May 10, 2020

Review app for commit 1a020d3 deployed to Heroku: https://hge-ci-pull-4570.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4570-1a020d31

@beerose beerose mentioned this pull request May 14, 2020
Closed
46 tasks
beerose
beerose suggested changes May 18, 2020
View reviewed changes
Copy link
Contributor

@beerose beerose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR! Looks great!

Left minor suggestion to rename OmittedButtonProps to ButtonProps.

@netlify
Copy link

netlify bot commented May 19, 2020 •
edited
Loading

Deploy preview for hasura-docs ready!

Built with commit a823623

https://deploy-preview-4570--hasura-docs.netlify.app

@kawamataryo
Copy link
Contributor Author

kawamataryo commented May 19, 2020

@beerose

Thank you for your review.
I fixed as suggest.
5b4afeb

@hasura-bot
Copy link
Contributor

hasura-bot commented May 19, 2020

Review app for commit 5b4afeb deployed to Heroku: https://hge-ci-pull-4570.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4570-5b4afeb8

beerose
beerose approved these changes May 25, 2020
View reviewed changes
Copy link
Contributor

@beerose beerose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good!

@hasura-bot
Copy link
Contributor

hasura-bot commented May 25, 2020

Review app for commit a823623 deployed to Heroku: https://hge-ci-pull-4570.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4570-a8236233

@beerose beerose requested a review from rikinsk May 26, 2020 09:40
@hasura-bot
Copy link
Contributor

hasura-bot commented May 27, 2020

Review app for commit 05af5c2 deployed to Heroku: https://hge-ci-pull-4570.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4570-05af5c27

@rikinsk rikinsk merged commit fb80784 into hasura:master May 27, 2020
@hasura-bot
Copy link
Contributor

hasura-bot commented May 27, 2020

Review app https://hge-ci-pull-4570.herokuapp.com is deleted

@hasura-bot
Copy link
Contributor

hasura-bot commented May 27, 2020

Beep boop! 🤖

GIF

Awesome work @kawamataryo! All of us at Hasura ❤️ what you did.

Thanks again 🤗

stevefan1999-personal pushed a commit to stevefan1999-personal/graphql-engine that referenced this pull request Sep 12, 2020
@kawamataryo @stevefan1999-personal
console: migrate Button to TypeScript (hasura#4570)
9534928
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rikinsk rikinsk rikinsk approved these changes

+1 more reviewer

@beerose beerose beerose approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@beerose beerose

@rikinsk rikinsk

Labels

c/console Related to console community-contrib 🙏🏽 no-changelog-required typescript-migration 🙌

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@kawamataryo @hasura-bot @beerose @rikinsk @marionschleifer