这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@wawhal
Copy link
Contributor

@wawhal wawhal commented Sep 14, 2018

No description provided.

Copy link
Member

@shahidhk shahidhk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wawhal Check the comments. Minor changes required.

@@ -0,0 +1,46 @@
# Contributor Covenant Code of Conduct
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wawhal Remove this file as we already have one at the root of repo.

@@ -0,0 +1,201 @@
Apache License
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the license as all community content/tools will be MIT licensed by default (as mentioned in https://github.com/hasura/graphql-engine/tree/master/community#license(

"grapql-engine",
"json"
],
"license": "Apache-2.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change license to MIT

Copy link
Member

@shahidhk shahidhk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wawhal Check the comments. Minor changes required.


## Testing

No pull request will be merged if it does not pass the tests.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make this welcoming, like: Please write tests also when you're adding a new feature.

# Import data from a JSON file to Hasura GraphQL Engine without access key
json2graphql https://hge.herokuapp.com --db=./path/to/db.js

# Make a query with CLI auto complete (this will show a gql prompt)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confused by this line. Residue from graphqurl?

@shahidhk shahidhk merged commit 68a2e03 into hasura:master Sep 17, 2018
@hasura-bot
Copy link
Contributor

Review app https://hge-ci-pull-454.herokuapp.com is deleted

@wawhal wawhal deleted the json2graphql branch September 18, 2018 13:29
hasura-bot pushed a commit that referenced this pull request Feb 2, 2021
GitOrigin-RevId: 112d3ac41a9914bac5981a9c57f66e5babf492be
hasura-bot pushed a commit that referenced this pull request Apr 23, 2024
## Description

This PR adds support for GraphQL variables in test cases. This can be
done by adding variables in `variables.json` file in the same directory
as the `request.gql`, `session_variables.json` files. This file is
optional.

Note that it expects a list of variable sets. Each item in the list
corresponds to a variable for each session in `session_variables.json`.
This is useful to run the same query, but with different variables for
different sessions.

Example `session_variables.json` -

```json
[
    {
        "x-hasura-role": "admin"
    },
    {
        "x-hasura-role": "user_1"
    },
    {
        "x-hasura-role": "user_2"
    }
]
```

Example `variables.json`

```json
[
    {
        "upper_bound": 4
    },
    {
        "upper_bound": 3
    },
    {
        "upper_bound": 2
    }
]
```

PS: this PR only modifies the `test_execution_expectation` function, and
not the `test_execution_expectation_legacy` function.

This PR is required to add some tests for #454

V3_GIT_ORIGIN_REV_ID: 31a6f8adc3521367960986d2bc070271ba3e2d73
hasura-bot pushed a commit that referenced this pull request Apr 23, 2024
Support field presets in input permissions of object types.

V3_GIT_ORIGIN_REV_ID: 55c024af40361d2f77e61dbf4114b57038b20ba5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants